-
-
Notifications
You must be signed in to change notification settings - Fork 169
refactor(ui): refactor utils #5207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ca13f5 to
13123a7
Compare
ca5e9c1 to
d93ede6
Compare
otavio
reviewed
Sep 6, 2025
8434c61 to
73d2033
Compare
otavio
previously approved these changes
Sep 8, 2025
73d2033 to
093e678
Compare
- remove duplicated util in admin - use utils inside components and remove the duplicated inner declarations
- add message for missing date cases - remove duplicated utils in admin
- simplify logic - remove duplicated admin util
- centralize all utils inside `src`, removing the admin's hooks folder
- simplify logic - remove redundant role check inside components
093e678 to
92a0723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the application's utils. The refactoring involves simplifying logic, removing unused utils, and reusing the main UI's utils in the admin, preventing code duplication.