refactor(api): simplify device authentication flow #4924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiytor
force-pushed
the
refactor/api/device-auth
branch
from
f83508b to
212a26e
Compare
otavio
previously approved these changes
Jun 17, 2025
heiytor
force-pushed
the
refactor/api/device-auth
branch
from
212a26e to
a64918b
Compare
otavio
requested changes
Jun 18, 2025
Refactor AuthDevice method to separate device creation from updates and remove struct intermediaries in cache operations. This improves code clarity and maintainability while preserving all existing functionality. - Replace upsert-based DeviceCreate with explicit create/update flow - Remove intermediate Device struct from cache operations using map[string]string - Move hostname derivation logic to service layer for better separation - Add explicit device status updates for existing devices going online - Improve error handling and add proper logging for cache operations - Update documentation to be concise and focused on core functionality DeviceCreate no longer returns insertion boolean, now focuses solely on creation with separate DeviceUpdate for modifications.
heiytor
force-pushed
the
refactor/api/device-auth
branch
from
a64918b to
f1416fd
Compare
otavio
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AuthDevice method to separate device creation from updates and remove struct intermediaries in cache operations. This improves code clarity and maintainability while preserving all existing functionality.
DeviceCreate no longer returns insertion boolean, now focuses solely on creation with separate DeviceUpdate for modifications.