fix(ui): fix player playback time for sessions longer than 24h #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizhf42
added
kind/bug
luizhf42
force-pushed
the
fix/player-time-formatting
branch
2 times, most recently
from
a3c95c2 to
a2f039e
Compare
luizhf42
force-pushed
the
fix/player-time-formatting
branch
from
a2f039e to
d89d25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the player's playback time formatting, making it behave properly in sessions longer than 1 day. The formatting logic was rewritten and moved to a separate util file. The tests were also updated to test the new util behavior.