Skip to content

fix(ui): fix player's time handlers #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavosbarreto merged 1 commit into from
Jun 3, 2025
Merged

fix(ui): fix player's time handlers #4883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ui/src/components/Sessions/Player.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,20 +118,20 @@ const currentSpeed = ref(1);

const changeFocusToPlayer = () => { playerWrapper.value?.focus(); };

const getCurrentTime = () => { currentTime.value = player.value.getCurrentTime(); };
const getCurrentTime = async () => { currentTime.value = await player.value.getCurrentTime(); };

const getDuration = () => { duration.value = player.value.getDuration(); };
const getDuration = async () => { duration.value = await player.value.getDuration(); };

const changePlaybackTime = (value: number) => {
const changePlaybackTime = async (value: number) => {
player.value.seek(value);
getCurrentTime();
await getCurrentTime();
};

const clearCurrentTimeUpdater = () => {
clearInterval(timeUpdaterId.value);
};

const startCurrentTimeUpdater = () => {
const startCurrentTimeUpdater = async () => {
clearCurrentTimeUpdater(); // clear to prevent multiple intervals when replaying
timeUpdaterId.value = window.setInterval(getCurrentTime, 100);
};
Expand Down Expand Up @@ -163,11 +163,11 @@ const createPlayer = (startAt = 0) => {
};

const setPlayerEventListeners = () => {
player.value.addEventListener("playing", () => {
player.value.addEventListener("playing", async () => {
sessionEnded.value = false;
getCurrentTime();
await getCurrentTime();
startCurrentTimeUpdater();
getDuration();
await getDuration();
});

player.value.addEventListener("ended", () => {
Expand All @@ -176,13 +176,13 @@ const setPlayerEventListeners = () => {
clearCurrentTimeUpdater();
});

useEventListener(containerDiv.value, "keydown", (event: KeyboardEvent) => {
getCurrentTime();
useEventListener(containerDiv.value, "keydown", async (event: KeyboardEvent) => {
await getCurrentTime();
if (event.key === "Escape") emit("close");
});

useEventListener(containerDiv.value, "keyup", () => {
getCurrentTime();
useEventListener(containerDiv.value, "keyup", async () => {
await getCurrentTime();
});
};

Expand Down