fix(ui): prevent tooltip click from triggering parent handlers #4868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop event propagation on SSH ID copy interactions to avoid unintended parent component behavior when clicking or pressing keys on the tooltip text.
luannmoreira
added
kind/bug
otavio
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with event propagation in the
QuickConnectionList.vuecomponent. Previously, when users clicked or pressed a key on the SSH ID text within the tooltip, the events would bubble up and potentially trigger unintended behavior in parent components.To resolve this,
.stopmodifiers have been added to the@clickand@keypressevents on the span that triggers the copy action. This ensures that the event is handled locally and does not propagate beyond the intended element, improving the reliability and predictability of user interactions with the tooltip.Why It Matters
Without stopping event propagation, UI components that rely on scoped interactions may behave unpredictably. For example, a parent component might react to the same click, causing side effects like modal closures or row selections. This change ensures a more intuitive and controlled UX when copying SSH IDs.