Fix bad type defs creeping into package #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Del depends on globby which I found was importing bad definitely typed files. In particular @types/glob would end up with a weird version of @types/minimatch. Bumping del to v6 fixes this. There's also nothing in this bump that is breaking changes and is the last version before Del is switched over to esm only (which I personally think is a better move but noticed prs vetoing it for that reason).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Del depends on globby which I found was importing bad definitely typed files. In particular @types/glob would end up with a weird version of @types/minimatch.
Bumping del to v6 fixes this. There's also nothing in this bump that is breaking changes and is the last version before Del is switched over to esm only (which I personally think is a better move but noticed prs vetoing it for that reason).