Skip to content

Upgrade eslint & related packages#116

Open
theclive wants to merge 6 commits intosheerun:masterfrom
theclive:upgrade-eslint
Open

Upgrade eslint & related packages#116
theclive wants to merge 6 commits intosheerun:masterfrom
theclive:upgrade-eslint

Conversation

@theclive
Copy link
Copy Markdown

This update fixes #114 by updating eslint and related packages to the latest versions.

Comment thread README.md

- eslint
- babel-eslint
- @babel/eslint-parser
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel-eslint was deprecated 6 months ago

Comment thread src/index.js
Comment on lines +125 to +127
parserOptions: {
requireConfigFile: false
},
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves the babel parsing error that throws for each file after upgrading to @babel/eslint-parser:

./prettier-standard/src/cli.js
  0:0  error  Parsing error: No Babel config file detected for ./prettier-standard/src/cli.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

./prettier-standard/src/index.js
  0:0  error  Parsing error: No Babel config file detected for ./prettier-standard/src/index.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

./prettier-standard/src/scms/git.js
  0:0  error  Parsing error: No Babel config file detected for ./prettier-standard/src/scms/git.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

./prettier-standard/src/utils.js
  0:0  error  Parsing error: No Babel config file detected for ./prettier-standard/src/utils.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

./prettier-standard/test/cli.test.js
  0:0  error  Parsing error: No Babel config file detected for ./prettier-standard/test/cli.test.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

./prettier-standard/test/index.test.js
  0:0  error  Parsing error: No Babel config file detected for ./prettier-standard/test/index.test.js. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files

Comment thread src/index.js
Comment on lines -134 to -141
getConfig('prettier', 'index.js'),
getConfig('prettier', '@typescript-eslint.js'),
getConfig('prettier', 'babel.js'),
getConfig('prettier', 'flowtype.js'),
getConfig('prettier', 'react.js'),
getConfig('prettier', 'standard.js'),
getConfig('prettier', 'unicorn.js'),
getConfig('prettier', 'vue.js')
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the breaking changes from v8.0.0 of eslint-config-prettier

@theclive theclive marked this pull request as ready for review March 30, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0

1 participant