perf: optimize path string parsing with substring slicing #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved parsing efficiency by replacing character-by-character string concatenation with native substring slicing operations. **Key optimization:** Substring slicing: Use input.slice(start, end) instead of building strings char-by-char, eliminating O(n²) behavior for long segment names. Smart escape handling: Only perform unescaping when escape sequences are detected via hasEscapes flag (fast path for 99% of segments). **Performance improvements:** - Overall average: +14% faster - Long segments (500 chars): +205% faster (~3x speedup!) - Real-world paths: +42-80% faster - Bracket notation: +20% faster - Deep nesting (26 levels): +8% faster - Many segments (50): +49% faster **Minor regression:** - Escaped characters: -6.7% (still 2.5M ops/sec, rare in practice) All 488 tests pass. Added comprehensive benchmark suite and detailed performance analysis. See benchmark/RESULTS.md for full details. **Note:** An initial regex-based number validation was tested but reverted as it slowed down simple single-digit number parsing. V8 optimizes Number() + toString() extremely well for common cases.
shaungrady
deleted the
claude/improve-path-parsing-01XdVpG9sy6AKt15jyiZLwaG
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved parsing efficiency by replacing character-by-character string
concatenation with native substring slicing operations.
Key optimization:
Substring slicing: Use input.slice(start, end) instead of building
strings char-by-char, eliminating O(n²) behavior for long segment names.
Smart escape handling: Only perform unescaping when escape sequences
are detected via hasEscapes flag (fast path for 99% of segments).
Performance improvements:
Minor regression:
All 488 tests pass. Added comprehensive benchmark suite and detailed
performance analysis. See benchmark/RESULTS.md for full details.
Note: An initial regex-based number validation was tested but
reverted as it slowed down simple single-digit number parsing. V8
optimizes Number() + toString() extremely well for common cases.