Skip to content

Commit

Permalink
feat: Renames Async streams to Asynchronous streams
Browse files Browse the repository at this point in the history
  • Loading branch information
ironcev committed Oct 10, 2019
1 parent c6f4d94 commit 5a1567f
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 10 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ The format of the file is based on [Keep a Changelog](http://keepachangelog.com/
- "What is/was new in C# X.Y?" link to MSDN documentation on C# version in the Sharpen Results view.
- "Learn more..." link to MSDN documentation on language features in the Sharpen Results view.

### Changed
- "Async streams" renamed to "Asynchronous streams".

## [0.9.0] - 2019-06-14
### Added
- "Consider replacing using statement with using declaration" suggestion.
Expand Down
2 changes: 1 addition & 1 deletion src/Sharpen.Engine/Analysis/SharpenAnalyzersHolder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using Sharpen.Engine.SharpenSuggestions.CSharp70.ExpressionBodiedMembers;
using Sharpen.Engine.SharpenSuggestions.CSharp70.OutVariables;
using Sharpen.Engine.SharpenSuggestions.CSharp71.DefaultExpressions;
using Sharpen.Engine.SharpenSuggestions.CSharp80.AsyncStreams.Analyzers;
using Sharpen.Engine.SharpenSuggestions.CSharp80.AsynchronousStreams.Analyzers;
using Sharpen.Engine.SharpenSuggestions.CSharp80.NullableReferenceTypes.Analyzers;
using Sharpen.Engine.SharpenSuggestions.CSharp80.SwitchExpressions.Analyzers;
using Sharpen.Engine.SharpenSuggestions.CSharp80.UsingDeclarations.Analyzers;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@

namespace Sharpen.Engine.CSharpFeatures
{
public class AsyncStreams : ICSharpFeature
public class AsynchronousStreams : ICSharpFeature
{
private AsyncStreams() { }
private AsynchronousStreams() { }

public ImmutableArray<string> LanguageVersions { get; } = ImmutableArray.CreateRange(new[] { CSharp80 });

public string FriendlyName { get; } = "Async streams";
public string FriendlyName { get; } = "Asynchronous streams";

public string LearnMoreUrl => "https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#asynchronous-streams";

public static readonly AsyncStreams Instance = new AsyncStreams();
public static readonly AsynchronousStreams Instance = new AsynchronousStreams();
}
}
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
using Sharpen.Engine.SharpenSuggestions.Common.AsyncAwaitAndAsyncStreams;
using static Sharpen.Engine.SharpenSuggestions.Common.AsyncAwaitAndAsyncStreams.EquivalentAsynchronousMethodFinder;

namespace Sharpen.Engine.SharpenSuggestions.CSharp80.AsyncStreams.Analyzers
namespace Sharpen.Engine.SharpenSuggestions.CSharp80.AsynchronousStreams.Analyzers
{
internal sealed class ConsiderAwaitingEquivalentAsynchronousMethodAndYieldingIAsyncEnumerableAnalyzer : BaseAwaitingEquivalentAsynchronousMethod
{
private ConsiderAwaitingEquivalentAsynchronousMethodAndYieldingIAsyncEnumerableAnalyzer() : base(CallerAsyncStatus.CallerMustNotBeAsync, CallerYieldingStatus.CallerMustYield) { }

public override string MinimumLanguageVersion { get; } = CSharpLanguageVersions.CSharp80;

public override ICSharpFeature LanguageFeature { get; } = CSharpFeatures.AsyncStreams.Instance;
public override ICSharpFeature LanguageFeature { get; } = CSharpFeatures.AsynchronousStreams.Instance;

public override string FriendlyName { get; } = "Consider awaiting equivalent asynchronous method and yielding IAsyncEnumerable";

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
namespace Sharpen.Engine.SharpenSuggestions.CSharp80.AsyncStreams.Suggestions
namespace Sharpen.Engine.SharpenSuggestions.CSharp80.AsynchronousStreams.Suggestions
{
// TODO-IG: This class is not used at the moment because the analyzer
// is implemented using the "old" approach because we wanted
Expand All @@ -11,7 +11,7 @@ private ConsiderAwaitingEquivalentAsynchronousMethodAndYieldingIAsyncEnumerable(

public string MinimumLanguageVersion { get; } = CSharpLanguageVersions.CSharp80;

public ICSharpFeature LanguageFeature { get; } = CSharpFeatures.AsyncStreams.Instance;
public ICSharpFeature LanguageFeature { get; } = CSharpFeatures.AsynchronousStreams.Instance;

public string FriendlyName { get; } = "Consider awaiting equivalent asynchronous method and yielding IAsyncEnumerable";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
using System.Threading;
using System.Threading.Tasks;

namespace CSharp80.AsyncStreams.ConsiderAwaitingEquivalentAsynchronousMethodAndYieldingIAsyncEnumerable
namespace CSharp80.AsynchronousStreams.ConsiderAwaitingEquivalentAsynchronousMethodAndYieldingIAsyncEnumerable
{
public class MethodsThatHaveEquivalentAsynchronousMethod
{
Expand Down

0 comments on commit 5a1567f

Please sign in to comment.