Allow atan2-arguments to be dimensionful

[sharkdp]

atan2(x, y) is basically just a safe version of atan(x / y). This means it should okay for x and y to be dimensionful as long as it's the same dimension. This would be useful to compute things like

> atan2(20 cm, 50 m)

[imacg]

I'd like to take this on. Would it make more sense to fix this in purescript-quantities?

[sharkdp]

Sounds great!

Would it make more sense to fix this in purescript-quantities?

Yes, we would have to start in purescript-quantities, Insects underlying library.

[imacg]

I've created a pull request in purescript-quantities. From what I can tell the fix in insect should only require a bump in the dependency's version.

Sorry if I screwed up some contribution protocol - it's my first open source contribution.

[sharkdp]

I've created a pull request in purescript-quantities

Thank you very much!

Sorry if I screwed up some contribution protocol - it's my first open source contribution.

You did great, thanks! 👍 I reviewed your PR and only have a small comment:
sharkdp/purescript-quantities#31 (review)

After that PR is merged, I can release a new purescript-quantities version and we can bump the dependency version here.