Default to $TERM unset = colour on Win32 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This otherwise respects all other configuration (NO_COLOR, TERM=dumb, &c.), but it's very common for the environment to be lacking TERM, which in that case usually means a pro-verbial TERM=cmd.exe, which is colourful Fixes: 049d113 ("Don't output colours by default if TERM=dumb or NO_COLOR=1")
nabijaczleweli
referenced
this pull request
Oct 24, 2022
This matches ZFS, and is mostly état d'art Closes #542
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This otherwise respects all other configuration (NO_COLOR, TERM=dumb, &c.), but it's very common for the environment to be lacking TERM, which in that case usually means a pro-verbial TERM=cmd.exe, which is colour-capable
Reported in 049d113#commitcomment-86934718