Hyperfine no longer auto assumes /C for windows if cmd.exe is not the selected shell. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilipAndersson245
changed the title
FilipAndersson245
changed the title
|
Thank you very much for your contribution! I understand that this fixes the behavior for nushell, but how about other shells on Windows, like PowerShell? |
|
I tested powershell and it supports both |
|
Anything more that has to be checked or can we close this issue @sharkdp? |
|
No, looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring we only use cmd-specific command building when cmd is in use, as this prevents alternative shells to be run on windows, like Nushell.
Closes #568