Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries #53

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Update libraries #53

merged 1 commit into from
Dec 1, 2023

Conversation

OttoAllmendinger
Copy link
Contributor

This change allows binocle to work on my system. Before it was crashing with

[2023-10-28T12:55:23Z WARN  wgpu_hal::vulkan::instance] \
  create_instance: VkError(ERROR_INCOMPATIBLE_DRIVER)
Error: No suitable `wgpu::Adapter` found.

Based off of https://github.com/parasyte/pixels/tree/main/examples/minimal-egui/src

@sharkdp
Copy link
Owner

sharkdp commented Nov 2, 2023

Thank you. The builds are currently failing. Any chance you could have a look?

This change allows binocle to work on my system. Before it was crashing with

```
[2023-10-28T12:55:23Z WARN  wgpu_hal::vulkan::instance] \
  create_instance: VkError(ERROR_INCOMPATIBLE_DRIVER)
Error: No suitable `wgpu::Adapter` found.
```

Based off of https://github.com/parasyte/pixels/tree/main/examples/minimal-egui/src
@OttoAllmendinger
Copy link
Contributor Author

I fixed the formatting now but I don't understand the build error for CICD / x86_64-pc-windows-gnu (windows-2019)

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. I'll disable the windows-gnu build for now. We still have the mvsc build on windows.

@sharkdp sharkdp merged commit 0db9f8f into sharkdp:master Dec 1, 2023
11 of 12 checks passed
sharkdp pushed a commit that referenced this pull request Dec 1, 2023
vortelus added a commit to vortelus/binocle that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants