Fix clippy suggestions

sharkdp · Apr 2, 2023 · 4bb5630 · 4bb5630
1 parent 9c4c7f1
commit 4bb5630
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/src/binocle.rs b/src/binocle.rs
@@ -119,8 +119,8 @@ impl Binocle {
 
         for (i, pixel) in frame.chunks_exact_mut(4).enumerate() {
             let zoom_factor = settings.zoom_factor();
-            let x = (((i as isize) % WIDTH as isize) as isize) / zoom_factor;
-            let y = (((i as isize) / WIDTH as isize) as isize) / zoom_factor;
+            let x = ((i as isize) % WIDTH as isize) / zoom_factor;
+            let y = ((i as isize) / WIDTH as isize) / zoom_factor;
 
             let color = if x >= settings.width {
                 [0, 0, 0, 0]

diff --git a/src/datatype.rs b/src/datatype.rs
@@ -97,14 +97,10 @@ impl Datatype {
                 .ok()
                 .map(|bytes| i64::from_be_bytes(bytes) as f32),
 
-            (Datatype::Float32, Endianness::Little) => slice
-                .try_into()
-                .ok()
-                .map(|bytes| f32::from_le_bytes(bytes) as f32),
-            (Datatype::Float32, Endianness::Big) => slice
-                .try_into()
-                .ok()
-                .map(|bytes| f32::from_be_bytes(bytes) as f32),
+            (Datatype::Float32, Endianness::Little) => {
+                slice.try_into().ok().map(f32::from_le_bytes)
+            }
+            (Datatype::Float32, Endianness::Big) => slice.try_into().ok().map(f32::from_be_bytes),
 
             (Datatype::Float64, Endianness::Little) => slice
                 .try_into()

diff --git a/src/event_loop.rs b/src/event_loop.rs
@@ -37,7 +37,7 @@ pub fn run(options: CliOptions) -> Result<()> {
     let window = {
         let size = LogicalSize::new(WIDTH as f64, HEIGHT as f64);
         WindowBuilder::new()
-            .with_title(&format!(
+            .with_title(format!(
                 "binocle - {}",
                 Path::new(&options.filename)
                     .file_name()