Make highlight tests fail when new syntaxes don't have fixtures #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-hipschman
force-pushed
the
fix-syntax-test-compare-script
branch
from
e435fc8 to
9272e09
Compare
keith-hall
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across #3236 (comment) and wanted to fix it.
For more context, a new language was added but the author forgot to run
update.shto add a test fixture for it. This should have caused CI to fail, but it passed. The reason is that the highlighting regression test scripts iterate over existing fixtures, and hence don't catch newly added languages that haven't added a fixture.