-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework lessopen
implementation to use execute
crate instead of run_script
#2805
Conversation
e838c8f
to
36d9566
Compare
Marking as draft because I realized my changes cause some of the integration tests to fail. Sorry for not catching it sooner. |
36d9566
to
11e4010
Compare
I fixed the issues with the integration tests. However, while troubleshooting them, I came across another potential concern that I am unsure how to resolve. I noticed that unlike what I assumed in my initial implementation,
Edit: Already investigated, see below. |
execute
crate instead of run_script
lessopen
implementation to use execute
crate instead of run_script
11e4010
to
450b73d
Compare
7ce06c5
to
1a1c4c3
Compare
4c3c86d
to
4355654
Compare
df1c0d4
to
a163674
Compare
After some testing, as far as I can tell, the Also while I was at it, I disabled the |
f9eb801
to
9ee5de3
Compare
9ee5de3
to
f77032a
Compare
44265b3
to
26274c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Head branch was pushed to by a user without write access
26274c6
to
96e4882
Compare
My bad, I saw it said auto-merge was enabled and it would be merged when it meets the requirements and I saw the thing saying my PR branch was behind on changes from master and I assumed that being up to date was one of the requirements. |
I replaced the
lessopen
implementation to use a crate calledexecute
instead of the currently-usedrun_script
. This has the benefit of simplifying the code a little, but more importantly fixes a few weird issues I noticed.The issues I noticed that these changes fix are:
batpipe
not working right when usingfish
as a shell. Currently,bat
shows the commands thatbatpipe
prints to configure$LESSOPEN
when you evaluate it in your startup config rather than the preprocessed file output.bat
not showing any output at all when usingglow
to preprocess markdown files.Edit: Also appears to fix some known issues with
lessopen
-related integration tests.