Make 'build-assets' an optional capability for application #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also structure features a bit more clever to avoid duplication of feature dependency declarations.
|
I think we should maybe be careful not to make the conditional compilation configuration too fine-grained to avoid combinatorial complexity, but the asset building seems like a very reasonable part to make optional 👍 |
sharkdp
approved these changes
Aug 12, 2021
|
I've done some additional verification now, and everything seems to work as it should. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main short-term benefit of this PR is to make building
minimal-application(previously calledquick-build-application) even faster.But it also opens up a major long-term possibility:
bat-assetsbinary to build assets, we can still allow users to optionally keep the current capability in the main appFor the curious, here are some numbers, comparing
minimal-applicationwithapplicationfor stripped release builds. Note that I am including trishume/syntect#345 in below numbers:minimal-applicationapplicationI have not yet done broad verification of this PR. Would be great to get your high-level feedback on it before I polish it.