Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] fzf integration sample from readme does not work #2095

Open
bw1faeh0 opened this issue Feb 28, 2022 · 1 comment
Open

[windows] fzf integration sample from readme does not work #2095

bw1faeh0 opened this issue Feb 28, 2022 · 1 comment
Labels
documentation help wanted Extra attention is needed windows Issue is related to the Windows build of bat

Comments

@bw1faeh0
Copy link

Hi,

On windows the fzf integration sample does not work out of the box.

bat/README.md

Line 121 in 7be9485

fzf --preview 'bat --color=always --style=numbers --line-range=:500 {}' 

❯ fzf --preview 'bat --color=always --style=numbers --line-range=:500 {}'
invalid color specification: always

You have to use " instead of ':

❯ fzf --preview "bat --color=always --style=numbers --line-range=:500 {}"

Maybe you can leave a note for windows users.
@Enselic Enselic added documentation windows Issue is related to the Windows build of bat labels Feb 28, 2022
@sharkdp
Copy link
Owner

sharkdp commented Feb 28, 2022

Thanks. The version with "…" should work just fine on Linux. There are no special shell characters that need escaping here. So we could just change this instead of adding an extra note for Windows users.

@Enselic Enselic added the help wanted Extra attention is needed label May 13, 2022
johnmatthiggins added a commit to johnmatthiggins/bat that referenced this issue Aug 2, 2023
@johnmatthiggins
fix for issue sharkdp#2095
b720af8
@johnmatthiggins johnmatthiggins mentioned this issue Aug 2, 2023
Merged
keith-hall added a commit that referenced this issue Aug 9, 2023
@keith-hall
Merge pull request #2639 from johnmatthiggins/doc_fix
00b7e3b 
fix for issue #2095
@github-actions github-actions bot mentioned this issue Jul 18, 2024
Merged
This was referenced Aug 16, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation help wanted Extra attention is needed windows Issue is related to the Windows build of bat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Enselic @sharkdp @bw1faeh0