Fix Guild Bans

[Droid00000]

Summary

Updates the ban API call, abstractions, and inline docs, to support cleaning messages as the old delete_message_days parameter has been replaced by delete_message_seconds, and adds support for sending an X-Audit-Log-Reason header.

Fixed

No audit log reason for guild bans, and broken clean messages parameter.

[Droid00000]

I've added back support for the message_days parameter. I've included message_seconds as an optional parameter to ease the transition to 4.0, when that eventually releases.

[expeehaa]

Shouldn’t this parameter be deprecated now and removed in 4.0?

[Droid00000]

As per what @swarley has said in DAPI I was told to keep the argument as is and add seconds as an optional KWARG.

[expeehaa]

I think that comment referred to keeping it in version 3.x, not in 4.0. In semantic versioning (semver), a breaking change, like a backwards incompatible method signature change, is only allowed during major version changes, such as 3.x to 4.0. A deprecation is a warning that it will be removed in a future version, in this case likely 4.0. Therefore, it should be deprecated now and removed in 4.0, not, as the comment claims, be deprecated in 4.0, which would imply its existence in 4.0 (and thus its removal not earlier than in 5.0).

[Droid00000]

I think that comment referred to keeping it in version 3.x, not in 4.0. In semantic versioning (semver), a breaking change, like a backwards incompatible method signature change, is only allowed during major version changes, such as 3.x to 4.0. A deprecation is a warning that it will be removed in a future version, in this case likely 4.0. Therefore, it should be deprecated now and removed in 4.0, not, as the comment claims, be deprecated in 4.0, which would imply its existence in 4.0 (and thus its removal not earlier than in 5.0).

Oh whoops. Seems like I misunderstood what you mean.

[Droid00000]

I've made a few changes and responded to most of the comments. Please take a look whenever you have the chance. 🙇‍♂️

[Droid00000]

As per what @swarley has said in DAPI I was told to keep the argument as is and add seconds as an optional KWARG.