Fix - Allow mixing groups and subcommands

[itsthedevman]

Summary

What is the problem I'm trying to solve?

I want to register the following commands:

/documents archive
/documents set password
/documents set owner
/documents show

What is happening that is unexpected?

Once the code gets to /documents show, it raises because /documents set (owner,password) has already been registered as a group. This structure is valid as described in Discord's API documentation.

Code example

bot = Discordrb::Bot.new(...)

bot.register_application_command(:documents, "", server_id: "") do |command|
  command.subcommand(:archive)

  command.subcommand_group(:set, "") do |group|
    group.subcommand(:password)
    group.subcommand(:owner)
  end

  command.subcommand(:show)
end

bot.application_command(:documents).subcommand(:archive) { |e| ... }

bot.application_command(:documents).group(:set) do |group|
  group.subcommand(:password) { |e| ... }
  group.subcommand(:owner) { |e| ... }
end

bot.application_command(:documents).subcommand(:show) { |e| ... }

Once the fix is in place, we can see the structure of the @subcommands hash is valid even with the mixture of groups and subcommands:

{:archive=>#<Proc:0x00001 (lambda)>,
 :show=>#<Proc:0x00004 (lambda)>,
 :set=>{:password=>#<Proc:0x00002 (lambda)>, :owner=>#<Proc:0x00003 (lambda)>}}

---

Fixed

• Added a name check during sub-command validation to allow mixing subcommands and groups so long as they don't share the same name.

[Droid00000]

Tested this out. Looks good to me.

[wouterdedroog]

Would love to see this merged into discordrb, I've been running on a fork with these changes and it's been working great.

[Droid00000]

Would love to see this merged into discordrb, I've been running on a fork with these changes and it's been working great.

I would like this as well.