Skip to content

fix: thor remove liquidity routing #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

Conversation

gomesalexandre
Copy link
Contributor

Description

Fixes incorrect THORCHain LP remove liquidity routing leaking over app routing, and staying when going to another route.

Issue (if applicable)

closes #9796

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • THOR Remove Liqudity feature still works and routing doesn't leak over browser routing (see issue/Jams)
  • UTXO that require a sweep step still work (i.e sweep step is triggered and we go to confirm after sweep seen). Easiest way to test if you have an UTXO position is to send all your funds to your next receive address for said account first

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

https://jam.dev/c/4b731236-2530-4242-bd65-20d6fc9641a8
https://jam.dev/c/e7684048-7ce3-4bed-b4d5-8ad772f18200

@gomesalexandre gomesalexandre requested a review from a team as a code owner June 26, 2025 10:45
Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jam.dev/c/d01a615a-b977-4ba9-9381-29e9a2d077bc

Does the do! Unfortunately I don't have any UTXO pool to test this, will defer to ops for the sweeping!

@gomesalexandre gomesalexandre enabled auto-merge (squash) June 26, 2025 16:04
@gomesalexandre gomesalexandre merged commit cda4835 into develop Jun 27, 2025
3 checks passed
@gomesalexandre gomesalexandre deleted the fix_rm_liquidity_routing branch June 27, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LP /remove route leaks over other routes
2 participants