chore: move market-service into lib #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodenfurniture
changed the title
webpack seems happy and not appreciably slower 🤌 |
woodenfurniture
force-pushed
the
move-market-service
branch
from
4efb077 to
0ff72b6
Compare
0xApotheosis
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move market-service into
/src/libso our package build is simpler and crashes developer LSP less frequently. Also removes a duplicate bignumber utility from market-service.Contains no logical changes.
Pull Request Type
Issue (if applicable)
NA
Risk
Low risk of broken market data.
Testing
Tested that app loads and market data is populating correctly.
Engineering
See above
Operations
Check that market data is working as expected.
Screenshots (if applicable)