Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more selectAssetEquityItemsByFilter selectors safety #4435

Merged
merged 2 commits into from
May 5, 2023

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented May 5, 2023

Description

This PR:

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

None, more safety

Testing

  • Go to assets
  • Open an asset
  • Asset properly opens, and opportunities are still displayed with no regressions after opportunities are loaded / reconciliated from persisted store (this should work with and without clearing your cache)
  • Try with a few assets, both with and without earn opportunities e.g ETH, RUNE (no opportunities), DOGE, mainnet USDC
  • Ensures reloading an asset page shows no regressions

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

image

image

image

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review May 5, 2023 07:29
@gomesalexandre gomesalexandre requested a review from a team as a code owner May 5, 2023 07:29
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedy fix, mate!

I couldn't replicate the throw I had before, so it looks like this did the trick.

@0xApotheosis 0xApotheosis enabled auto-merge (squash) May 5, 2023 07:46
@0xApotheosis 0xApotheosis merged commit debc3c0 into develop May 5, 2023
@0xApotheosis 0xApotheosis deleted the feat_more_portfolio_selectors_safety branch May 5, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants