fix: all circular imports fixed #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackedq
changed the title
Deploying with
|
| Latest commit: |
d16706a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://341a0035.web-29e.pages.dev |
src/context/WalletProvider/KeepKey/hooks/useKeepKeyEventHandler.ts
Outdated
Show resolved
Hide resolved
* chore: WIP moving modals to WalletProvider * fix: native password and kk pin modal migrated * fix: migrated the keepkey passphrase modal to live under wallet context Co-authored-by: theoboldfrazier <theobold.frazier@gmail.com> Co-authored-by: stackedQ <stackedQ@gmail.com>
cjthompson
approved these changes
Apr 1, 2022
elmutt
approved these changes
Apr 1, 2022
theoboldfrazier
approved these changes
Apr 1, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed all remaining circular imports and migrates
KeepkeyPin,KeepkeyPassphrase, and nativePasswordModalinto the WalletModal and using the state in useWallet.Notice
Pull Request Type
Issue (if applicable)
Circular imports were littered throughout web. This was causing some optimization issues on load, but overall did not present itself until recently. A certain PR had caused the app to get stuck in an infinite refresh loop on iPhone only. Investigating the cause, we decided to start removing circular imports to see if we could get the app to load on iPhone and it worked, validating our idea that circular imports had gotten inefficient enough to cause an issue on iPhone load.
This PR removes all circular imports and put's into CI that a circular import will fail the build, ensuring that no more will be added in the future.
Risk
There is overall regression risk throughout the application. There are also higher regression risks to the native password entry, the keepkey pin entry, and the keepkey passphrase entry. The app did seem to be working pretty well locally, and in our manual testing no regressions were found.
Testing
Testing the keepkey pin entry, keepkey passphrase entry and native wallet password entry for bugs is needed. Also overall regression testing will be needed since 128 files were touched in removing the circular dependencies.
Screenshots (if applicable)