Remove the select box

Signed-off-by: Oleksii Orel <oorel@redhat.com>
shaohelv · Jul 26, 2019 · ca28a9b · ca28a9b
1 parent 8200bb5
commit ca28a9b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/dashboard/src/app/stacks/list-stacks/list-stacks.controller.ts b/dashboard/src/app/stacks/list-stacks/list-stacks.controller.ts
@@ -61,7 +61,9 @@ export class ListStacksController {
     });
 
     this.orderBy = DEFAULT_COLUMN;
-    this.searchBy = DEFAULT_COLUMN;
+
+    // todo remove this after cheListHelper improvement
+    this.searchBy = 'tmpFilterColumn';
 
     this.loadDevfiles();
   }
@@ -73,6 +75,10 @@ export class ListStacksController {
       const devfileMetaDatas = data.map((devfileMetaData: IDevfileMetaData) => {
         const globalMemoryLimit = this.$filter('changeMemoryUnit')(devfileMetaData.globalMemoryLimit, ['MB','GB']);
         devfileMetaData.globalMemoryLimit = globalMemoryLimit;
+
+        // todo remove this after cheListHelper improvement
+        devfileMetaData[this.searchBy]= `${devfileMetaData.displayName} ${devfileMetaData.description} ${globalMemoryLimit}`;
+
         return devfileMetaData;
       });
       this.cheListHelper.setList(devfileMetaDatas, DEFAULT_COLUMN);

diff --git a/dashboard/src/app/stacks/list-stacks/list-stacks.html b/dashboard/src/app/stacks/list-stacks/list-stacks.html
@@ -19,17 +19,6 @@
 <md-content md-scroll-y flex layout="column" md-theme="maincontent-theme" class=stacks-list-content>
   <md-progress-linear md-mode="indeterminate" class="stacks-list-progress"
                       ng-show="listStacksController.isLoading"></md-progress-linear>
-  <div class="apply-filter-to-selected-column"
-       uib-tooltip="Choose a column to apply a filter"
-       tooltip-append-to-body="true">
-    <select ng-model="listStacksController.searchBy"
-            ng-change="listStacksController.updateFilters()"
-            class="che-list-item-details">
-      <option value="displayName">Name</option>
-      <option value="description">Description</option>
-      <option value="globalMemoryLimit">Required memory</option>
-    </select>
-  </div>
   <che-list-header che-input-placeholder="Search"
                    che-search-model="listStacksController.stackFilter.name"
                    che-on-search-change="listStacksController.onSearchChanged(str)"

diff --git a/dashboard/src/app/stacks/list-stacks/list-stacks.styl b/dashboard/src/app/stacks/list-stacks/list-stacks.styl
@@ -1,17 +1,6 @@
 .stacks-list-content
-  position relative
   margin 0
 
-  .apply-filter-to-selected-column
-    position absolute
-    right 190px
-    top 15px
-
-    select
-      text-transform uppercase
-      outline none
-      height 35px
-
   .devfile-selector-icon-column
     width 110px