Skip to content

Commit

Permalink
Disables upstream features flagged by security/privacy teams.
Browse files Browse the repository at this point in the history
  • Loading branch information
mkarolin committed Nov 27, 2023
1 parent 750d1de commit ad8ce55
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 0 deletions.
9 changes: 9 additions & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
&apps::features::kDesktopPWAsLinkCapturing,
#endif
&attribution_reporting::features::kAttributionReportingTriggerConfig,
&attribution_reporting::features::kConversionMeasurement,
&autofill::features::kAutofillEnableRemadeDownstreamMetrics,
&autofill::features::test::kAutofillServerCommunication,
Expand All @@ -129,6 +130,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&blink::features::kAdAuctionReportingWithMacroApi,
&blink::features::kAdInterestGroupAPI,
&blink::features::kAllowURNsInIframes,
&blink::features::kAttributionReportingInBrowserMigration,
&blink::features::kBackgroundResourceFetch,
&blink::features::kBiddingAndScoringDebugReportingAPI,
&blink::features::kBrowsingTopics,
Expand All @@ -148,7 +150,9 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&blink::features::kPrerender2,
&blink::features::kPrivacySandboxAdsAPIs,
&blink::features::kPrivateAggregationApi,
&blink::features::kPrivateAggregationApiMultipleCloudProviders,
&blink::features::kSharedStorageAPI,
&blink::features::kSharedStorageAPIM118,
&blink::features::kSharedStorageSelectURLLimit,
&blink::features::kSpeculationRulesHeaderEnableThirdPartyOriginTrial,
&blink::features::kSpeculationRulesPrefetchFuture,
Expand Down Expand Up @@ -182,6 +186,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&features::kBookmarkTriggerForPrerender2,
&features::kChromeLabs,
&features::kChromeRefresh2023,
&features::kCookieDeprecationFacilitatedTesting,
#if !BUILDFLAG(IS_ANDROID)
&features::kCopyLinkToText,
#endif
Expand All @@ -196,6 +201,9 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
#endif
&features::kIdleDetection,
&features::kKAnonymityService,
&features::kKAnonymityServiceOHTTPRequests,
&features::kLegacyTechReportEnableCookieIssueReports,
&features::kLegacyTechReportTopLevelUrl,
&features::kNotificationTriggers,
&features::kOmniboxTriggerForNoStatePrefetch,
&features::kOmniboxTriggerForPrerender2,
Expand Down Expand Up @@ -287,6 +295,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
#endif
&permissions::features::kPermissionOnDeviceNotificationPredictions,
&permissions::features::kPermissionStorageAccessAPI,
&permissions::features::kShowRelatedWebsiteSetsPermissionGrants,
&privacy_sandbox::kEnforcePrivacySandboxAttestations,
&privacy_sandbox::kOverridePrivacySandboxSettingsLocalTesting,
&privacy_sandbox::kPrivacySandboxFirstPartySetsUI,
Expand Down
1 change: 1 addition & 0 deletions chromium_src/chrome/common/chrome_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ namespace features {

OVERRIDE_FEATURE_DEFAULT_STATES({{
{kKAnonymityService, base::FEATURE_DISABLED_BY_DEFAULT},
{kKAnonymityServiceOHTTPRequests, base::FEATURE_DISABLED_BY_DEFAULT},
{kPrivacyGuide3, base::FEATURE_DISABLED_BY_DEFAULT},
#if BUILDFLAG(IS_ANDROID)
{kPrivacyGuideAndroid, base::FEATURE_DISABLED_BY_DEFAULT},
Expand Down
1 change: 1 addition & 0 deletions chromium_src/components/attribution_reporting/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
namespace attribution_reporting::features {

OVERRIDE_FEATURE_DEFAULT_STATES({{
{kAttributionReportingTriggerConfig, base::FEATURE_DISABLED_BY_DEFAULT},
{kConversionMeasurement, base::FEATURE_DISABLED_BY_DEFAULT},
}});

Expand Down
2 changes: 2 additions & 0 deletions chromium_src/components/permissions/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{
{kRecordPermissionExpirationTimestamps, base::FEATURE_DISABLED_BY_DEFAULT},
#endif
{kPermissionStorageAccessAPI, base::FEATURE_DISABLED_BY_DEFAULT},
{kShowRelatedWebsiteSetsPermissionGrants,
base::FEATURE_DISABLED_BY_DEFAULT},
}});

} // namespace features
Expand Down
4 changes: 4 additions & 0 deletions chromium_src/content/public/common/content_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,15 @@ namespace features {

OVERRIDE_FEATURE_DEFAULT_STATES({{
{kAttributionFencedFrameReportingBeacon, base::FEATURE_DISABLED_BY_DEFAULT},
{kCookieDeprecationFacilitatedTesting, base::FEATURE_DISABLED_BY_DEFAULT},
{kDigitalGoodsApi, base::FEATURE_DISABLED_BY_DEFAULT},
{kDIPS, base::FEATURE_DISABLED_BY_DEFAULT},
{kFedCm, base::FEATURE_DISABLED_BY_DEFAULT},
{kFirstPartySets, base::FEATURE_DISABLED_BY_DEFAULT},
{kIdleDetection, base::FEATURE_DISABLED_BY_DEFAULT},
{kLegacyTechReportEnableCookieIssueReports,
base::FEATURE_DISABLED_BY_DEFAULT},
{kLegacyTechReportTopLevelUrl, base::FEATURE_DISABLED_BY_DEFAULT},
{kNotificationTriggers, base::FEATURE_DISABLED_BY_DEFAULT},
{kPrivacySandboxAdsAPIsOverride, base::FEATURE_DISABLED_BY_DEFAULT},
{kSignedHTTPExchange, base::FEATURE_DISABLED_BY_DEFAULT},
Expand Down
5 changes: 5 additions & 0 deletions chromium_src/third_party/blink/common/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{
{kAdAuctionReportingWithMacroApi, base::FEATURE_DISABLED_BY_DEFAULT},
{kAdInterestGroupAPI, base::FEATURE_DISABLED_BY_DEFAULT},
{kAllowURNsInIframes, base::FEATURE_DISABLED_BY_DEFAULT},
{kAttributionReportingInBrowserMigration,
base::FEATURE_DISABLED_BY_DEFAULT},
{kBackgroundResourceFetch, base::FEATURE_DISABLED_BY_DEFAULT},
{kBiddingAndScoringDebugReportingAPI, base::FEATURE_DISABLED_BY_DEFAULT},
{kBrowsingTopics, base::FEATURE_DISABLED_BY_DEFAULT},
Expand All @@ -40,8 +42,11 @@ OVERRIDE_FEATURE_DEFAULT_STATES({{
{kPrerender2, base::FEATURE_DISABLED_BY_DEFAULT},
{kPrivacySandboxAdsAPIs, base::FEATURE_DISABLED_BY_DEFAULT},
{kPrivateAggregationApi, base::FEATURE_DISABLED_BY_DEFAULT},
{kPrivateAggregationApiMultipleCloudProviders,
base::FEATURE_DISABLED_BY_DEFAULT},
{kReduceUserAgentMinorVersion, base::FEATURE_ENABLED_BY_DEFAULT},
{kSharedStorageAPI, base::FEATURE_DISABLED_BY_DEFAULT},
{kSharedStorageAPIM118, base::FEATURE_DISABLED_BY_DEFAULT},
{kSharedStorageSelectURLLimit, base::FEATURE_DISABLED_BY_DEFAULT},
{kSpeculationRulesHeaderEnableThirdPartyOriginTrial,
base::FEATURE_DISABLED_BY_DEFAULT},
Expand Down

0 comments on commit ad8ce55

Please sign in to comment.