refactor: add possibility to support different URI schemes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
urischeme-support
branch
from
9b656e9
to
3577771
Compare
JKRhb
force-pushed
the
urischeme-support
branch
2 times, most recently
from
0982a54
to
e8c6d29
Compare
JKRhb
force-pushed
the
urischeme-support
branch
from
e8c6d29
to
1bc18fa
Compare
refactor: add possibility to support different URI schemes
|
This looks OK to me, I take it it's now ready to merge, just checking. |
|
@shamblett Thank you for your feedback :) Besides the merge conflict it would be ready, however, maybe the change could also be incorporated into @JosefWN's PR #76? |
|
I can incorporate it if you want and if @shamblett is ok with it, working on mutlicast and adding more examples/tests to find and work out any issues in the PR |
|
No problem from me with this approach. |
|
Hope I didn't miss anything: 4a44d63 :) Also includes a fix for a formatting issue I had caused in the builder, which I discovered when I re-generated the CoapConfigs (which I did just in case). |
|
Awesome, thank you :) Then I'll close this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dealing with the addition of DTLS to the library, I noticed that the current structure of the library does not really allow for differentiating between URI schemes. This PR proposes a new structure that allows for adding additional network and channel types that can be chosen based on the URI scheme that is encountered.
This way, in contrast to what is currently proposed in #35, additional ways of transporting CoAP packets can be defined in their own classes and do not need to be integrated into the UDP channel/network classes. This also makes the library easier to extend with features like CoAP over TCP or CoAP over WebSockets.
Unfortunately, this PR requires #35 to be rebased/adjusted (sorry @Sorunome) but I hope it won't be too much work :/