feat: add constructors and client methods for new CoAP methods #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
commented
Aug 10, 2022
|
LGTM |
Adds new named constructors for requests using the newly added FETCH, PATCH, and iPATCH methods
|
@shamblett Do you think this could be merged? Or do you see anything that should be changed here? |
|
Hi, Im on hols at the mo and so dont have my dev environment available I can however merge stuff so if you guys think something is ready please update the PR and Ill press the buttons. I wont be back in action gill around 30th September |
|
Hi all, OK back in action, this looks OK to me, if no other shouts I'll merge it. |
Welcome back!
That would be great, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively simple PR that adds support for the newly defined
FETCH,PATCH, andiPATCHmethods to theCoapClientandCoapRequestclasses. It could be included in the 5.0.0 release but we might as well integrate it in 5.1.0.CC @JosefWN