Rework option system #122
Rework option system #122
Conversation
|
Just to hijack this slightly are we now good to go for a 5.0.0 release, there's been a lot put in since 4.2.1 |
Oh, yeah, sorry, I think we can go forward with a 5.0.0 release :) Although I made some good progress here already, this PR is probably something for the next major release (after 5.0.0). |
|
I think this PR would now be ready for an initial review (CC @JosefWN). If you think the PR is close to being mergeable, we could include it in the 5.0.0 release. As mentioned above, we could also include it in a later release. |
|
Applied a couple of further improvements, making options actually immutable and providing a very basic OSCORE option implementation. I think there is still some more work to be done, so I would definitely postpone this after the 5.0.0 release. |
|
Ok will do Ive targetted the 5.0.0 release for this Friday |
Okay, great :) |
|
Performed some more cleanup and resolved a few remaining issues. I think this PR should now be ready for another (final?) review :) |
JKRhb
force-pushed
the
coap-options
branch
6 times, most recently
from
133edcb
to
4d9fb67
Compare
|
Rebased the PR and provided a couple of additional test cases for invalid option formats. |
|
Added a last minute fix for the encoding of the OSCORE option. |
|
Rebased the PR against the latest upstream version. Now it should finally be ready to be merged :) |
JKRhb
force-pushed
the
coap-options
branch
4 times, most recently
from
f2fdd08
to
a5862c0
Compare
|
Noticed an issue with the endianness of the integer option again... Should be fixed now. I am applying a couple of last changes, then this should actually be ready to be merged. |
I am currently working on an overhaul of the option implementation. This PR is still WIP but I already wanted to share my progress with you.