refactor!: rework CoapCode and CoapMessageType as enhanced enums
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
coap-code
branch
2 times, most recently
from
99f2618
to
94081ed
Compare
JosefWN
reviewed
Jul 18, 2022
JosefWN
reviewed
Jul 18, 2022
JosefWN
reviewed
Jul 18, 2022
JosefWN
reviewed
Jul 18, 2022
|
I incorporated the suggestions and squashed the commits :) |
JosefWN
reviewed
Jul 18, 2022
| @@ -128,24 +123,7 @@ class CoapReliabilityLayer extends CoapAbstractLayer { | |||
| final CoapResponse? response, | |||
| ) { | |||
| final mt = response!.type; | |||
| if (mt == CoapMessageType.unknown) { | |||
There was a problem hiding this comment.
Haven't read all of the code and a little sleepy. When would this happen, if the server sent an invalid response and/or if the response was corrupted in flight? I take it with your change we won't acknowledge that message then, meaning that the server will resend the response? Sounds reasonable
|
LGTM! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
CoapCodeandCoapMessageTypeclasses as enhanced enums (also see #80), making the code more concise and readable. The changes also make it easier to add moreCoapCodes in the future. The PR itself adds a few missingCoapCodes from the IANA registry, including the new method codesFETCH,PATCH, andiPATCH.CC @JosefWN