fix no error on modal close , publish v2.1.17-beta.1

CHANGELOG.md

@@ -1,3 +1,6 @@
+### Release v2.1.17-beta.1
+- fix error not getting thrown on window close, if desired behavior
+
 ### Release v2.1.16
 - fix invalid import
 

example/app/src/App.vue

@@ -276,6 +276,7 @@ export default {
 
     // Initialize the provider based client
     // this.connect = new mewConnect.Provider({windowClosedError: true, rpcUrl: 'ws://127.0.0.1:8545', /*chainId: 1*/});
+    // 859569f6decc4446a5da1bb680e7e9cf
     this.connect = new mewConnect.Provider({windowClosedError: true, rpcUrl: 'wss://mainnet.infura.io/ws/v3/859569f6decc4446a5da1bb680e7e9cf'});
     this.connect.on('popupWindowClosed', () =>{
       console.log(`popup window closed EVENT`);
@@ -339,17 +340,21 @@ export default {
     animateConnectedNotifier() {
       this.connect.showConnectedNotice();
     },
-    onClick() {
-      this.ethereum.send('eth_requestAccounts').then(accounts => {
-        console.log(`User's address is ${accounts[0]}`);
-        this.userAddress = accounts[0];
-      });
-      console.log(mewConnect.Provider.isConnected); // todo remove dev item
-      // this.ethereum.enable().then(accounts => {
+    async onClick() {
+      try{
+       const accounts =  await this.ethereum.enable()
+          console.log(`User's address is ${accounts[0]}`);
+          this.userAddress = accounts[0];
+      } catch(e){
+        console.error(e); // todo replace with proper error
+      }
+      // this.ethereum.send('eth_requestAccounts').then(accounts => {
       //   console.log(`User's address is ${accounts[0]}`);
       //   this.userAddress = accounts[0];
       // })
       // .catch(console.error)
+      console.log(mewConnect.Provider.isConnected); // todo remove dev item
+
     },
     disconnect() {
       this.connect.disconnect();

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@myetherwallet/mewconnect-web-client",
   "homepage": "https://github.com/myetherwallet/MEWconnect-web-client",
-  "version": "2.1.16",
+  "version": "2.1.17-beta.1",
   "main": "./dist/index.js",
   "module": "./src/index.js",
   "scripts": {

src/connectProvider/index.js

@@ -91,20 +91,21 @@ export default class Integration extends EventEmitter {
     );
   }
 
-  async enable() {
-    return new Promise((resolve, reject) => {
-      nativeCheck().then(res => {
-        if (res) {
-          if (MEWconnectWallet.getConnectionState() === 'disconnected') {
-            this.returnPromise = this.enabler();
-          }
-          if (typeof popUpCreator.popupWindowOpen === 'boolean') {
-            popUpCreator.showDialog();
-          }
-          return resolve(this.returnPromise);
+  enable() {
+    return nativeCheck().then(res => {
+      if (res) {
+        if (MEWconnectWallet.getConnectionState() === 'disconnected') {
+          this.returnPromise = this.enabler();
         }
-      });
+        if (typeof popUpCreator.popupWindowOpen === 'boolean') {
+          popUpCreator.showDialog();
+        }
+        return this.returnPromise;
+      }
     });
+    // return new Promise((resolve, reject) => {
+    //
+    // });
   }
 
   enabler() {

src/connectWindow/popUpCreator.js

@@ -106,6 +106,7 @@ export default class PopUpCreator {
     this.popupWindowOpen = null;
     this.hideNotifier();
     this.closePopupWindow();
+    this.windowClosedListener();
   }
 
   createQrCodeModal() {