Add missed react_component_hash functionality #960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I created #951, I forgot to add the useful functionality from #950 that would ensure that
react_component_hash
worked correctly. When there is a prerendering error,react_component_hash
should return the result combined with the console logs as a hash even though every prerendering error is returned fromExec
as a String. Right now, if a prerendering error occurs,react_component_hash
throws its "Expected a Hash" errorExpected Behavior:
Current Behavior:
This change is