Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed react_component_hash functionality #960

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Conversation

Judahmeek
Copy link
Contributor

@Judahmeek Judahmeek commented Oct 20, 2017

When I created #951, I forgot to add the useful functionality from #950 that would ensure that react_component_hash worked correctly. When there is a prerendering error, react_component_hash should return the result combined with the console logs as a hash even though every prerendering error is returned from Exec as a String. Right now, if a prerendering error occurs, react_component_hash throws its "Expected a Hash" error

Expected Behavior:
screen_shot_2017-10-19_at_2_55_00_am

Current Behavior:
screen_shot_2017-10-18_at_11_41_39_pm


This change is Reviewable

@justin808
Copy link
Member

:lgtm:. Ready to merge? and release? Needs a CHANGELOG and doc entry.


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


spec/dummy/package.json, line 10 at r1 (raw file):

    "lint": "cd client && yarn run lint",
    "build:clean": "rm -rf public/webpack || true",
    "build:production:client": "(cd client && yarn run build:production:client --silent)",

why did this change?


Comments from Reviewable

@Judahmeek
Copy link
Contributor Author

I'd like to get the rest of my PRs reviewed, fixed, approved, and merged before release.


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


spec/dummy/package.json, line 10 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

why did this change?

Because with yarn v1, the old syntax sends the --silent option to webpack, which then throws an error.


Comments from Reviewable

@justin808
Copy link
Member

Why no CHANGELOG.md and doc change, @Judahmeek?


Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@Judahmeek
Copy link
Contributor Author

My bad, @justin808. For some reason, I was thinking that CHANGELOG updates were only required on release. I forgot about the unreleased section. That said, I don't think any doc changes are required since this PR simply ensured that react_component_hash actually returns a hash every time.

Btw, #957 is also ready for re-review.


Review status: 11 of 12 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@justin808
Copy link
Member

:lgtm:


Review status: 11 of 12 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@justin808
Copy link
Member

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@justin808 justin808 merged commit c1bce8f into master Oct 24, 2017
@Judahmeek Judahmeek deleted the jmeek/hash-errors branch October 24, 2017 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants