Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contentBase deprecation warning message #878

Merged
merged 1 commit into from
Jul 1, 2017

Conversation

ened
Copy link
Contributor

@ened ened commented Jun 22, 2017

Without the change, I had the error message:

22:05:30 hot-assets.1 | started with pid 9115
22:05:31 hot-assets.1 | yarn run v0.24.5
22:05:31 hot-assets.1 | $ (cd client && yarn run hot-assets) 
22:05:31 hot-assets.1 | yarn run v0.24.5
22:05:31 hot-assets.1 | $ NODE_ENV=development babel-node server-rails-hot.js 
22:05:33 hot-assets.1 | Webpack HOT dev build for Rails
22:05:33 hot-assets.1 | Using a URL as contentBase is deprecated and will be removed in the next major version. Please use the proxy option instead.
22:05:33 hot-assets.1 | proxy: {
22:05:33 hot-assets.1 | 	"*": "<your current contentBase configuration>"
22:05:33 hot-assets.1 | }
22:05:33 hot-assets.1 | Using a URL as contentBase is deprecated and will be removed in the next major version. Please use the proxy option instead.

This change is Reviewable

@justin808
Copy link
Member

Thanks @ened

@justin808 justin808 merged commit c34602a into shakacode:master Jul 1, 2017
@ened ened deleted the patch-2 branch July 21, 2017 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants