Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rails to 4.2.8 #735

Merged
merged 2 commits into from
Feb 24, 2017
Merged

Conversation

hrishimittal
Copy link
Contributor

@hrishimittal hrishimittal commented Feb 23, 2017

Upgrade to latest Rails 4 version as a fix for security vulnerabilities in 4.2.5.


This change is Reviewable

Upgrade to latest Rails 4 version as a fix for security vulnerabilities in 4.2.5.
@hrishimittal
Copy link
Contributor Author

I expect the tests to fail until #734 is merged.

@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 99.329% when pulling b74819b on hrishimittal:upgrade-rails into 3106b4b on shakacode:master.

@justin808
Copy link
Member

One small comment.

Then probably OK for merge.


Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


CHANGELOG.md, line 9 at r1 (raw file):

*Please add entries here for your pull requests.*

## [6.6.2] - 2017-02-23

you don't need to set a version and release line

I'll be doing that.

Also, this would be Fixed (maybe changed)

Added is for new functionality and requires a bump to something like 6.7.

I'm not going to do a release on bumping the version of rails used to build the gem...

the version that matters is what people use in their apps.


Comments from Reviewable

@hrishimittal
Copy link
Contributor Author

@justin808 Thanks for the comment. I've updated the PR. We should probably make it clear in CONTRIBUTING.md that you set the version and release.

@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 99.329% when pulling 14ee30e on hrishimittal:upgrade-rails into 3106b4b on shakacode:master.

@justin808 justin808 merged commit 4943fbd into shakacode:master Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants