Skip to content

Fix broken image issue #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Fix broken image issue #1757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added docs/assets/early-hydration-performance-comparison.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/react-on-rails-pro/major-performance-breakthroughs-upgrade-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ This optimization is particularly impactful for:

_Performance improvement visualization:_

![Performance comparison showing early hydration improvement](https://github.com/user-attachments/assets/ae33fe14-42f1-4cc1-bde3-9c5bb570cdbf)
![Performance comparison showing early hydration improvement](../assets/early-hydration-performance-comparison.jpg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Local image path may still 404 unless the asset is added and the docs pipeline serves docs/assets.

  • Confirm the image file is committed at docs/assets/early-hydration-performance-comparison.jpg.
  • Ensure your docs tool (GitHub rendering, Jekyll, Docusaurus, etc.) serves assets from docs/assets via relative paths. Docusaurus typically expects files under website/static/img and links like /img/...; Jekyll often uses /assets or a baseurl prefix.

If you’re using Docusaurus, consider moving the image to static/img and updating the path:

-![Performance comparison showing early hydration improvement](../assets/early-hydration-performance-comparison.jpg)
+![Performance comparison showing early hydration improvement](/img/early-hydration-performance-comparison.jpg)

Optionally, use a compressed .webp to reduce repo weight:

-![Performance comparison showing early hydration improvement](../assets/early-hydration-performance-comparison.jpg)
+![Performance comparison showing early hydration improvement](../assets/early-hydration-performance-comparison.webp)

Run to verify existence and detect docs tooling:

🏁 Script executed:

#!/bin/bash
# 1) Verify the asset exists (case-sensitive)
fd -tf -p '^early-hydration-performance-comparison\.(jpg|jpeg|png|webp)$' docs

# 2) Show likely docs tooling
fd -tf -HI 'docusaurus.config.*|mkdocs.y*ml|_config.yml|package.json' | sed 's/^/tooling: /'

# 3) Grep for other image references to align conventions
rg -n '!\[.*\]\((\.\./)?assets/.*\)' docs -C1

Length of output: 1208

Add missing image asset and verify serving

  • Add docs/assets/early-hydration-performance-comparison.jpg (or an optimized .webp) so the Markdown link resolves.
  • Ensure your docs build pipeline serves files from docs/assets via the ../assets/... path. If you’re on Docusaurus, move the image to static/img and update the link to /img/early-hydration-performance-comparison.jpg.
🤖 Prompt for AI Agents 
In docs/react-on-rails-pro/major-performance-breakthroughs-upgrade-guide.md
around line 74 the referenced image
../assets/early-hydration-performance-comparison.jpg is missing causing a broken
link; add the image file (preferably optimized .webp) at
docs/assets/early-hydration-performance-comparison.jpg or, if the site uses
Docusaurus, move the image to static/img and update the Markdown link to
/img/early-hydration-performance-comparison.jpg; then verify the docs build
pipeline serves that directory (or update static asset config) and rebuild to
confirm the image resolves.


_The image above demonstrates the dramatic performance improvement:_

Expand Down
Loading