Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always generate append_X_pack calls if not in development #1545

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

Judahmeek
Copy link
Contributor

@Judahmeek Judahmeek commented Jun 13, 2023

Summary

Instead of creating an append_X_pack call conditional on the existence of the generated pack entrypoint, the new logic will always create the append_X_pack call for the component as long as the component's render option's auto_load_bundle is true in test or production environments.

In the development environment, however, a missing generated pack entrypoint will result in a raised error message.

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Other Information

Remove this paragraph and mention any other important and relevant information such as benchmarks.


This change is Reviewable

@Judahmeek Judahmeek requested a review from justin808 June 13, 2023 04:21
@justin808
Copy link
Member

@Judahmeek any changelog entry?

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please add changelog and merge, @Judahmeek

@Judahmeek Judahmeek force-pushed the judahmeek/autoload-pack-check branch from 585f28e to acf6e42 Compare June 14, 2023 21:35
@Judahmeek Judahmeek merged commit 43efef2 into master Jun 14, 2023
@Judahmeek Judahmeek deleted the judahmeek/autoload-pack-check branch June 14, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants