Fix unmounting in React 18 #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #1460. |
alexeyr-ci1
force-pushed
the
alexeyr/react18-fix-unmount
branch
from
79ec9c0
to
eafccca
Compare
4 tasks
alexeyr-ci1
force-pushed
the
alexeyr/react18-fix-unmount
branch
from
8177dfc
to
a67b65c
Compare
alexeyr-ci1
force-pushed
the
alexeyr/react18-fix-unmount
branch
from
bd755b0
to
30837a1
Compare
|
@tomdracz, @summera Any chance that you can take a look here? LGTM. @alexeyr-ci1 what's left for React 18? |
#1463 and the third task in #1464 (but that's just a doc change). Unless we come up with some nice idea about avoiding multiple roots, but that's probably in the future. |
|
Looks good! |
|
If CI passes with react 18 in spec/dummy, I'm merging. |
justin808
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is