Fix Generator to use Exact NPM Version #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin808
force-pushed
the
justin808/fix-tests
branch
2 times, most recently
from
6812342
to
b49fc3e
Compare
justin808
force-pushed
the
justin808/fix-tests
branch
3 times, most recently
from
c9b5df8
to
a289062
Compare
Otherwise npm is using the latest version, which might be the matching version if a patch was put on a prior release.
justin808
force-pushed
the
justin808/fix-tests
branch
from
a289062
to
5d8c130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has probably been failing due to the generator adding node package 11.3.1 since that was released after 12.0.3.
This fix will have the generator install the exact version.
This change is