Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 helpers to get hashed file names #1018

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jan 24, 2018

Added 2 cache helpers:

ReactOnRails::Utils.bundle_file_name(bundle_name)
ReactOnRails::Utils.server_bundle_file_name

for easy access to the hashed filenames for use in cache keys


This change is Reviewable

@robwise
Copy link
Contributor

robwise commented Jan 24, 2018

:lgtm:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@coveralls
Copy link

coveralls commented Jan 24, 2018

Coverage Status

Coverage remained the same at ?% when pulling 32c6fd6 on add-bundle-name-helpers into 8c8077b on master.

Added 2 cache helpers:

ReactOnRails::Utils.bundle_file_name(bundle_name)
ReactOnRails::Utils.server_bundle_file_name

for easy access to the hashed filenames for use in cache keys
@justin808 justin808 merged commit 99e0341 into master Jan 24, 2018
@justin808 justin808 deleted the add-bundle-name-helpers branch January 24, 2018 05:53
justin808 added a commit that referenced this pull request Jan 24, 2018
Added 2 cache helpers:

ReactOnRails::Utils.bundle_file_name(bundle_name)
ReactOnRails::Utils.server_bundle_file_name

for easy access to the hashed filenames for use in cache keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants