Skip to content

Commit 8d4b4c4

Browse files
improve redis tear down
1 parent 3954ee2 commit 8d4b4c4

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

react_on_rails_pro/spec/dummy/app/controllers/pages_controller.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,12 @@ def redis_receiver
8282
Rails.logger.error "Error writing Items to Redis: #{e.message}"
8383
Rails.logger.error e.backtrace.join("\n")
8484
raise e
85+
ensure
86+
begin
87+
redis&.close
88+
rescue StandardError => close_err
89+
Rails.logger.warn "Failed to close Redis: #{close_err.message}"
90+
end
8591
end
8692

8793
stream_view_containing_react_components(template: "/pages/redis_receiver")

react_on_rails_pro/spec/dummy/e2e-tests/fixture.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,11 @@ const redisControlledTest = base.extend<RedisRequestIdFixture, RedisClientFixtur
3030
const client = createClient({ url });
3131
await client.connect();
3232
await use(client as RedisClientType);
33-
await client.close();
33+
await client.quit();
3434
}, { scope: 'worker' }],
3535

3636
redisRequestId: async ({ redisClient }, use) => {
3737
await use(randomUUID());
38-
redisClient.del
3938
},
4039

4140
nonBlockingNavigateWithRequestId: async ({ redisRequestId, page }, use) => {

0 commit comments

Comments
 (0)