Skip to content

Commit 3954ee2

Browse files
tiny fixes
1 parent 5d7cfa2 commit 3954ee2

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ jobs:
389389
working_directory: react_on_rails_pro/spec/dummy
390390
command: yarn e2e-test
391391
- store_test_results:
392-
path: react_on_rails_pro/spec/dummy/results.xml
392+
path: react_on_rails_pro/spec/dummy/test-results/results.xml
393393
- store_artifacts:
394394
path: react_on_rails_pro/spec/dummy/playwright-report
395395

react_on_rails_pro/spec/dummy/client/app/ror-auto-load-components/RedisReceiver.jsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const RedisItemWithWrapper = ({ getValue, itemIndex }) => (
2020
// To test the page behavior when a client component is rendered asynchronously at the page
2121
const AsyncToggleContainer = async ({ children, childrenTitle, getValue }) => {
2222
await getValue('ToggleContainer');
23-
return <ToggleContainer children={children} childrenTitle={childrenTitle} />
23+
return <ToggleContainer childrenTitle={childrenTitle}>{children}</ToggleContainer>
2424
}
2525

2626
const RedisReceiver = ({ requestId, asyncToggleContainer }, railsContext) => {
@@ -31,14 +31,16 @@ const RedisReceiver = ({ requestId, asyncToggleContainer }, railsContext) => {
3131
}
3232

3333
const UsedToggleContainer = asyncToggleContainer ? AsyncToggleContainer : ToggleContainer;
34-
const toggleContainerGetValueParam = asyncToggleContainer ? getValue : undefined;
3534

3635
return () => (
3736
<ErrorBoundary>
3837
<main className='redis-receiver-container'>
3938
<h1 className="redis-receiver-header">A list of items received from Redis:</h1>
4039
<Suspense fallback={<div>Loading ToggleContainer</div>}>
41-
<UsedToggleContainer childrenTitle="Redis Items" getValue={toggleContainerGetValueParam}>
40+
<UsedToggleContainer
41+
childrenTitle="Redis Items"
42+
{...(toggleContainerGetValueParam ? { getValue } : {})}
43+
>
4244
<ol className='redis-items-container'>
4345
{
4446
[0,1,2,3,4].map(index => <RedisItemWithWrapper key={index} getValue={getValue} itemIndex={index} />)

0 commit comments

Comments
 (0)