refactor: convert Procfile templates from dynamic to static shakapacker references

Replace ERB template processing with static Procfiles using 'shakapacker' directly
instead of dynamic <%= config[:packer_type] %> detection, per Justin's feedback.

**Templates → Static Files:**
- Convert Procfile.dev.tt → Procfile.dev (static shakapacker references)
- Convert Procfile.dev-static.tt → Procfile.dev-static (static shakapacker references)
- Add Procfile.dev-static-assets (for bin/dev static mode)
- Add Procfile.dev-prod-assets (for bin/dev production-asset mode)

**Generator Updates:**
- Update base_generator.rb to copy Procfiles as static files instead of templates
- Remove dependency on ReactOnRails::PackerUtils.packer_type for Procfiles

**Script Updates:**
- Update bin/dev scripts to reference Procfile.dev-static-assets for static mode
- Update dummy app bin/dev to match generator template

**Test Updates:**
- Update dev_spec.rb to expect new Procfile names
- Update shared examples to verify all 4 Procfiles are generated
- Update test dummy files to use correct Procfile references

Addresses feedback from PR review about updating Procfiles to match
react_on_rails-demo-v15-ssr-auto-registration-bundle-splitting repo.

Author: ihabadham

lib/generators/react_on_rails/base_generator.rb

@@ -29,10 +29,12 @@ def create_react_directories
       def copy_base_files
         base_path = "base/base/"
         base_files = %w[app/controllers/hello_world_controller.rb
-                        app/views/layouts/hello_world.html.erb]
-        base_templates = %w[config/initializers/react_on_rails.rb
-                            Procfile.dev
-                            Procfile.dev-static]
+                        app/views/layouts/hello_world.html.erb
+                        Procfile.dev
+                        Procfile.dev-static
+                        Procfile.dev-static-assets
+                        Procfile.dev-prod-assets]
+        base_templates = %w[config/initializers/react_on_rails.rb]
         base_files.each { |file| copy_file("#{base_path}#{file}", file) }
         base_templates.each do |file|
           template("#{base_path}/#{file}.tt", file, { packer_type: ReactOnRails::PackerUtils.packer_type })

lib/generators/react_on_rails/bin/dev

@@ -68,9 +68,9 @@ def run_static_development
   generate_packs
 
   if installed? "overmind"
-    system "overmind start -f Procfile.dev-static"
+    system "overmind start -f Procfile.dev-static-assets"
   elsif installed? "foreman"
-    system "foreman start -f Procfile.dev-static"
+    system "foreman start -f Procfile.dev-static-assets"
   else
     warn <<~MSG
       NOTICE:
@@ -81,7 +81,7 @@ def run_static_development
 rescue Errno::ENOENT
   warn <<~MSG
     ERROR:
-    Please ensure `Procfile.dev-static` exists in your project!
+    Please ensure `Procfile.dev-static-assets` exists in your project!
   MSG
   exit!
 end

lib/generators/react_on_rails/templates/base/base/Procfile.dev

@@ -0,0 +1,5 @@
+# Procfile for development using HMR
+# You can run these commands in separate shells
+rails: bundle exec rails s -p 3000
+wp-client: bin/shakapacker-dev-server
+wp-server: SERVER_BUNDLE_ONLY=yes bin/shakapacker --watch

lib/generators/react_on_rails/templates/base/base/Procfile.dev-prod-assets

@@ -0,0 +1,8 @@
+# Procfile for development with production assets 
+# Uses production-optimized, precompiled assets with development environment
+# Uncomment additional processes as needed for your app
+
+rails: bundle exec rails s -p 3001
+# sidekiq: bundle exec sidekiq -C config/sidekiq.yml
+# redis: redis-server
+# mailcatcher: mailcatcher --foreground

lib/generators/react_on_rails/templates/base/base/Procfile.dev-static.tt renamed to lib/generators/react_on_rails/templates/base/base/Procfile.dev-static

@@ -5,5 +5,5 @@ web: rails s -p 3000
 # When making frequent changes to client side assets, you will prefer building webpack assets
 # upon saving rather than when you refresh your browser page.
 # Note, if using React on Rails localization you will need to run
-# `bundle exec rake react_on_rails:locale` before you run bin/<%= config[:packer_type] %>
-webpack: sh -c 'rm -rf public/packs/* || true && bin/<%= config[:packer_type] %> -w'
+# `bundle exec rake react_on_rails:locale` before you run bin/shakapacker
+webpack: sh -c 'rm -rf public/packs/* || true && bin/shakapacker -w'

lib/generators/react_on_rails/templates/base/base/Procfile.dev-static-assets

@@ -0,0 +1,2 @@
+web: bin/rails server -p 3000
+js: bin/shakapacker --watch

lib/generators/react_on_rails/templates/base/base/Procfile.dev.tt

@@ -68,9 +68,9 @@ def run_static_development
   generate_packs
 
   if installed? "overmind"
-    system "overmind start -f Procfile.dev-static"
+    system "overmind start -f Procfile.dev-static-assets"
   elsif installed? "foreman"
-    system "foreman start -f Procfile.dev-static"
+    system "foreman start -f Procfile.dev-static-assets"
   else
     warn <<~MSG
       NOTICE:
@@ -81,7 +81,7 @@ def run_static_development
 rescue Errno::ENOENT
   warn <<~MSG
     ERROR:
-    Please ensure `Procfile.dev-static` exists in your project!
+    Please ensure `Procfile.dev-static-assets` exists in your project!
   MSG
   exit!
 end

spec/dummy/bin/dev

@@ -33,7 +33,7 @@ def setup_script_execution
   it "supports static development mode" do
     script_content = File.read(script_path)
     expect(script_content).to include("run_static_development")
-    expect(script_content).to include("Procfile.dev-static")
+    expect(script_content).to include("Procfile.dev-static-assets")
   end
 
   it "supports production-like mode" do

spec/react_on_rails/binstubs/dev_spec.rb

@@ -20,6 +20,8 @@
        app/javascript/bundles/HelloWorld/components/HelloWorld.jsx
        config/initializers/react_on_rails.rb
        Procfile.dev
-       Procfile.dev-static].each { |file| assert_file(file) }
+       Procfile.dev-static
+       Procfile.dev-static-assets
+       Procfile.dev-prod-assets].each { |file| assert_file(file) }
   end
 end