let shakapacker handle package manager for us

Author: ihabadham

lib/generators/react_on_rails/install_generator.rb

@@ -62,15 +62,7 @@ def invoke_generators
       # js(.coffee) are not checked by this method, but instead produce warning messages
       # and allow the build to continue
       def installation_prerequisites_met?
-        !(missing_node? || missing_npm? || ReactOnRails::GitUtils.uncommitted_changes?(GeneratorMessages))
-      end
-
-      def missing_npm?
-        return false unless ReactOnRails::Utils.running_on_windows? ? `where npm`.blank? : `which npm`.blank?
-
-        error = "npm is required. Please install it before continuing. https://docs.npmjs.com/downloading-and-installing-node-js-and-npm"
-        GeneratorMessages.add_error(error)
-        true
+        !(missing_node? || ReactOnRails::GitUtils.uncommitted_changes?(GeneratorMessages))
       end
 
       def missing_node?

spec/react_on_rails/generators/install_generator_spec.rb

@@ -75,12 +75,6 @@
       allow(install_generator).to receive(:`).with("which node").and_return("/path/to/bin")
       expect(install_generator.send(:missing_node?)).to be false
     end
-
-    specify "when npm is exist" do
-      stub_const("RUBY_PLATFORM", "linux")
-      allow(install_generator).to receive(:`).with("which npm").and_return("/path/to/bin")
-      expect(install_generator.send(:missing_npm?)).to be false
-    end
   end
 
   context "when detecting missing bin-files on *nix" do
@@ -91,12 +85,6 @@
       allow(install_generator).to receive(:`).with("which node").and_return("")
       expect(install_generator.send(:missing_node?)).to be true
     end
-
-    specify "when npm is missing" do
-      stub_const("RUBY_PLATFORM", "linux")
-      allow(install_generator).to receive(:`).with("which npm").and_return("")
-      expect(install_generator.send(:missing_npm?)).to be true
-    end
   end
 
   context "when detecting existing bin-files on windows" do
@@ -107,12 +95,6 @@
       allow(install_generator).to receive(:`).with("where node").and_return("/path/to/bin")
       expect(install_generator.send(:missing_node?)).to be false
     end
-
-    specify "when npm is exist" do
-      stub_const("RUBY_PLATFORM", "mswin")
-      allow(install_generator).to receive(:`).with("where npm").and_return("/path/to/bin")
-      expect(install_generator.send(:missing_npm?)).to be false
-    end
   end
 
   context "when detecting missing bin-files on windows" do
@@ -123,12 +105,6 @@
       allow(install_generator).to receive(:`).with("where node").and_return("")
       expect(install_generator.send(:missing_node?)).to be true
     end
-
-    specify "when npm is missing" do
-      stub_const("RUBY_PLATFORM", "mswin")
-      allow(install_generator).to receive(:`).with("where npm").and_return("")
-      expect(install_generator.send(:missing_npm?)).to be true
-    end
   end
 
   context "when detecting Shakapacker installation" do