Fix server bundle path duplication by handling nested absolute paths

- Handle case where both source_path and source_entry_path are absolute
- Extract relative entry path when source_entry_path contains source_path
- Remove debug logging since issue is resolved
- Add test case for nested absolute path scenario

This fixes the issue where paths like:
/app/client/app + /app/client/app/packs → client/app/packs (correct)
instead of: client/app/app/client/app/packs (incorrect)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: justin808

lib/react_on_rails/doctor.rb

@@ -312,32 +312,26 @@ def determine_server_bundle_path
         source_path = Shakapacker.config.source_path.to_s
         source_entry_path = Shakapacker.config.source_entry_path.to_s
         server_bundle_filename = get_server_bundle_filename
+        rails_root = Dir.pwd
 
-        # Debug info - remove after fixing
-        checker.add_info("🔍 Debug - Raw source_path: #{source_path}")
-        checker.add_info("🔍 Debug - Raw source_entry_path: #{source_entry_path}")
-        checker.add_info("🔍 Debug - Rails root (Dir.pwd): #{Dir.pwd}")
-
-        # If source_path is absolute, make it relative to current directory
-        if source_path.start_with?("/")
-          # Convert absolute path to relative by removing the Rails root
-          rails_root = Dir.pwd
-          if source_path.start_with?(rails_root)
-            source_path = source_path.sub("#{rails_root}/", "")
-            checker.add_info("🔍 Debug - Converted to relative: #{source_path}")
-          else
-            # If it's not under Rails root, just use the basename
-            source_path = File.basename(source_path)
-            checker.add_info("🔍 Debug - Using basename: #{source_path}")
-          end
+        # Convert absolute paths to relative paths
+        if source_path.start_with?("/") && source_path.start_with?(rails_root)
+          source_path = source_path.sub("#{rails_root}/", "")
         end
 
-        final_path = File.join(source_path, source_entry_path, server_bundle_filename)
-        checker.add_info("🔍 Debug - Final path: #{final_path}")
-        final_path
-      rescue LoadError, NameError, StandardError => e
+        if source_entry_path.start_with?("/") && source_entry_path.start_with?(rails_root)
+          source_entry_path = source_entry_path.sub("#{rails_root}/", "")
+        end
+
+        # If source_entry_path is already within source_path, just use the relative part
+        if source_entry_path.start_with?(source_path)
+          # Extract just the entry path part (e.g., "packs" from "client/app/packs")
+          source_entry_path = source_entry_path.sub("#{source_path}/", "")
+        end
+
+        File.join(source_path, source_entry_path, server_bundle_filename)
+      rescue LoadError, NameError, StandardError
         # Fallback to default paths if Shakapacker is not available or configured
-        checker.add_info("🔍 Debug - Shakapacker error: #{e.message}")
         server_bundle_filename = get_server_bundle_filename
         "app/javascript/packs/#{server_bundle_filename}"
       end

spec/lib/react_on_rails/doctor_spec.rb

@@ -118,6 +118,24 @@
         end
       end
 
+      context "when Shakapacker gem returns nested absolute paths" do
+        let(:rails_root) { "/Users/test/myapp" }
+        let(:shakapacker_config) { double(source_path: "#{rails_root}/client/app", source_entry_path: "#{rails_root}/client/app/packs") }
+
+        before do
+          shakapacker_module = double("Shakapacker", config: shakapacker_config)
+          stub_const("Shakapacker", shakapacker_module)
+          allow(doctor).to receive(:require).with("shakapacker").and_return(true)
+          allow(doctor).to receive(:get_server_bundle_filename).and_return("server-bundle.js")
+          allow(Dir).to receive(:pwd).and_return(rails_root)
+        end
+
+        it "handles nested absolute paths correctly" do
+          path = doctor.send(:determine_server_bundle_path)
+          expect(path).to eq("client/app/packs/server-bundle.js")
+        end
+      end
+
       context "when Shakapacker gem is not available" do
         before do
           allow(doctor).to receive(:require).with("shakapacker").and_raise(LoadError)