Add temporary debug info to diagnose path duplication issue

Author: justin808

lib/react_on_rails/doctor.rb

@@ -313,21 +313,31 @@ def determine_server_bundle_path
         source_entry_path = Shakapacker.config.source_entry_path.to_s
         server_bundle_filename = get_server_bundle_filename
 
+        # Debug info - remove after fixing
+        checker.add_info("🔍 Debug - Raw source_path: #{source_path}")
+        checker.add_info("🔍 Debug - Raw source_entry_path: #{source_entry_path}")
+        checker.add_info("🔍 Debug - Rails root (Dir.pwd): #{Dir.pwd}")
+
         # If source_path is absolute, make it relative to current directory
         if source_path.start_with?("/")
           # Convert absolute path to relative by removing the Rails root
           rails_root = Dir.pwd
           if source_path.start_with?(rails_root)
             source_path = source_path.sub("#{rails_root}/", "")
+            checker.add_info("🔍 Debug - Converted to relative: #{source_path}")
           else
             # If it's not under Rails root, just use the basename
             source_path = File.basename(source_path)
+            checker.add_info("🔍 Debug - Using basename: #{source_path}")
           end
         end
 
-        File.join(source_path, source_entry_path, server_bundle_filename)
-      rescue LoadError, NameError, StandardError
+        final_path = File.join(source_path, source_entry_path, server_bundle_filename)
+        checker.add_info("🔍 Debug - Final path: #{final_path}")
+        final_path
+      rescue LoadError, NameError, StandardError => e
         # Fallback to default paths if Shakapacker is not available or configured
+        checker.add_info("🔍 Debug - Shakapacker error: #{e.message}")
         server_bundle_filename = get_server_bundle_filename
         "app/javascript/packs/#{server_bundle_filename}"
       end

lib/react_on_rails/system_checker.rb

@@ -146,6 +146,7 @@ def check_react_on_rails_packages
       check_react_on_rails_gem
       check_react_on_rails_npm_package
       check_package_version_sync
+      check_gemfile_version_patterns
     end
 
     def check_react_on_rails_gem
@@ -200,13 +201,14 @@ def check_package_version_sync
 
         if clean_npm_version == gem_version
           add_success("✅ React on Rails gem and NPM package versions match (#{gem_version})")
+          check_version_patterns(npm_version, gem_version)
         else
           add_warning(<<~MSG.strip)
             ⚠️  Version mismatch detected:
             • Gem version: #{gem_version}
             • NPM version: #{npm_version}
 
-            Consider updating to matching versions for best compatibility.
+            Consider updating to exact, fixed matching versions of gem and npm package for best compatibility.
           MSG
         end
       rescue JSON::ParserError
@@ -374,6 +376,50 @@ def report_dependency_status(required_deps, missing_deps, package_json)
       MSG
     end
 
+    def check_version_patterns(npm_version, gem_version)
+      # Check for version range patterns in package.json
+      if npm_version.match(/^[\^~]/)
+        pattern_type = npm_version[0] == '^' ? 'caret (^)' : 'tilde (~)'
+        add_warning(<<~MSG.strip)
+          ⚠️  NPM package uses #{pattern_type} version pattern: #{npm_version}
+
+          While versions match, consider using exact version "#{gem_version}" in package.json
+          for guaranteed compatibility with the React on Rails gem.
+        MSG
+      end
+    end
+
+    def check_gemfile_version_patterns
+      gemfile_path = ENV["BUNDLE_GEMFILE"] || "Gemfile"
+      return unless File.exist?(gemfile_path)
+
+      begin
+        gemfile_content = File.read(gemfile_path)
+        react_on_rails_line = gemfile_content.lines.find { |line| line.match(/^\s*gem\s+['"]react_on_rails['"]/) }
+
+        return unless react_on_rails_line
+
+        # Check for version patterns in Gemfile
+        if react_on_rails_line.match(/['"][~^]/)
+          add_warning(<<~MSG.strip)
+            ⚠️  Gemfile uses version pattern for react_on_rails gem.
+
+            Consider using exact version in Gemfile for guaranteed compatibility:
+            gem 'react_on_rails', '#{ReactOnRails::VERSION}'
+          MSG
+        elsif react_on_rails_line.match(/['>]=/)
+          add_warning(<<~MSG.strip)
+            ⚠️  Gemfile uses version range (>=) for react_on_rails gem.
+
+            Consider using exact version in Gemfile for guaranteed compatibility:
+            gem 'react_on_rails', '#{ReactOnRails::VERSION}'
+          MSG
+        end
+      rescue StandardError
+        # Ignore errors reading Gemfile
+      end
+    end
+
     def report_dependency_versions(package_json)
       all_deps = package_json["dependencies"]&.merge(package_json["devDependencies"] || {}) || {}
 

spec/lib/react_on_rails/system_checker_spec.rb

@@ -192,6 +192,70 @@
     end
   end
 
+  describe "#check_version_patterns" do
+    it "warns about caret version patterns" do
+      checker.send(:check_version_patterns, "^16.0.0", "16.0.0")
+      expect(checker.warnings?).to be true
+      expect(checker.messages.last[:content]).to include("caret (^) version pattern")
+    end
+
+    it "warns about tilde version patterns" do
+      checker.send(:check_version_patterns, "~16.0.0", "16.0.0")
+      expect(checker.warnings?).to be true
+      expect(checker.messages.last[:content]).to include("tilde (~) version pattern")
+    end
+
+    it "does not warn about exact versions" do
+      initial_message_count = checker.messages.count
+      checker.send(:check_version_patterns, "16.0.0", "16.0.0")
+      expect(checker.messages.count).to eq(initial_message_count)
+    end
+  end
+
+  describe "#check_gemfile_version_patterns" do
+    context "when Gemfile has version patterns" do
+      let(:gemfile_content) do
+        <<~GEMFILE
+          gem 'rails', '~> 7.0'
+          gem 'react_on_rails', '~> 16.0'
+          gem 'other_gem'
+        GEMFILE
+      end
+
+      before do
+        allow(File).to receive(:exist?).with("Gemfile").and_return(true)
+        allow(File).to receive(:read).with("Gemfile").and_return(gemfile_content)
+        stub_const("ReactOnRails::VERSION", "16.0.0")
+      end
+
+      it "warns about tilde version patterns" do
+        checker.send(:check_gemfile_version_patterns)
+        expect(checker.warnings?).to be true
+        expect(checker.messages.last[:content]).to include("Gemfile uses version pattern")
+      end
+    end
+
+    context "when Gemfile has exact versions" do
+      let(:gemfile_content) do
+        <<~GEMFILE
+          gem 'rails', '7.0.0'
+          gem 'react_on_rails', '16.0.0'
+        GEMFILE
+      end
+
+      before do
+        allow(File).to receive(:exist?).with("Gemfile").and_return(true)
+        allow(File).to receive(:read).with("Gemfile").and_return(gemfile_content)
+      end
+
+      it "does not warn about exact versions" do
+        initial_message_count = checker.messages.count
+        checker.send(:check_gemfile_version_patterns)
+        expect(checker.messages.count).to eq(initial_message_count)
+      end
+    end
+  end
+
   describe "#check_react_on_rails_npm_package" do
     context "when package.json exists with react-on-rails" do
       let(:package_json_content) do