Skip to content

Commit 4350858

Browse files
justin808claude
andcommitted
Fix Node.js 22 V8 cache crash by reverting to Node 20
The previous attempt to disable yarn caching for Node 22 using cache: '' caused CI failures because GitHub Actions setup-node doesn't accept empty strings for the cache parameter and still attempts to initialize caching, resulting in "Could not get yarn cache folder path" errors. This commit reverts all workflows to use Node 20 until the V8 bug is resolved. This is a temporary workaround that ensures CI stability. Changes: - Revert lint-js-and-ruby.yml from Node 22 to Node 20 with normal caching - Revert main.yml matrix to use Node 20 for both latest and minimum dependency levels - Simplify package-js-tests.yml to only test Node 20 - Remove conditional cache logic that was causing failures - Remove conditional frozen-lockfile flag that depended on Node 22 Related: nodejs/node#56010 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent ae5425b commit 4350858

File tree

3 files changed

+8
-23
lines changed

3 files changed

+8
-23
lines changed

.github/workflows/lint-js-and-ruby.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,8 @@ jobs:
5454
- name: Setup Node
5555
uses: actions/setup-node@v4
5656
with:
57-
node-version: 22
58-
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
59-
# Disable cache for Node 22 due to V8 bug in 22.21.0
60-
# Track: https://github.com/nodejs/node/issues/56010
61-
cache: ''
57+
node-version: 20
58+
cache: 'yarn'
6259
cache-dependency-path: '**/yarn.lock'
6360
- name: Print system information
6461
run: |

.github/workflows/main.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
include:
4646
# Always run: Latest versions (fast feedback on PRs)
4747
- ruby-version: '3.4'
48-
node-version: '22'
48+
node-version: '20'
4949
dependency-level: 'latest'
5050
# Master only: Minimum supported versions (full coverage)
5151
- ruby-version: '3.2'
@@ -69,9 +69,7 @@ jobs:
6969
uses: actions/setup-node@v4
7070
with:
7171
node-version: ${{ matrix.node-version }}
72-
# Disable cache for Node 22 due to V8 bug in 22.21.0
73-
# https://github.com/nodejs/node/issues/56010
74-
cache: ${{ matrix.node-version != '22' && 'yarn' || '' }}
72+
cache: 'yarn'
7573
cache-dependency-path: '**/yarn.lock'
7674
- name: Print system information
7775
run: |
@@ -150,9 +148,7 @@ jobs:
150148
uses: actions/setup-node@v4
151149
with:
152150
node-version: ${{ matrix.node-version }}
153-
# Disable cache for Node 22 due to V8 bug in 22.21.0
154-
# https://github.com/nodejs/node/issues/56010
155-
cache: ${{ matrix.node-version != '22' && 'yarn' || '' }}
151+
cache: 'yarn'
156152
cache-dependency-path: '**/yarn.lock'
157153
- name: Print system information
158154
run: |

.github/workflows/package-js-tests.yml

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,7 @@ jobs:
4747
(github.ref == 'refs/heads/master' || needs.detect-changes.outputs.run_js_tests == 'true')
4848
strategy:
4949
matrix:
50-
include:
51-
# Always run: Latest Node version (fast feedback on PRs)
52-
- node-version: '22'
53-
# Master only: Minimum supported Node version (full coverage)
54-
- node-version: '20'
50+
node-version: ['20']
5551
runs-on: ubuntu-22.04
5652
steps:
5753
- uses: actions/checkout@v4
@@ -61,10 +57,7 @@ jobs:
6157
uses: actions/setup-node@v4
6258
with:
6359
node-version: ${{ matrix.node-version }}
64-
# TODO: Re-enable cache when Node.js 22 V8 bug is fixed
65-
# Disable cache for Node 22 due to V8 bug in 22.21.0
66-
# Track: https://github.com/nodejs/node/issues/56010
67-
cache: ${{ matrix.node-version != '22' && 'yarn' || '' }}
60+
cache: 'yarn'
6861
cache-dependency-path: '**/yarn.lock'
6962
- name: Print system information
7063
run: |
@@ -74,11 +67,10 @@ jobs:
7467
echo "Node version: "; node -v
7568
echo "Yarn version: "; yarn --version
7669
- name: run conversion script
77-
if: matrix.node-version == '20'
7870
run: script/convert
7971
- name: Install Node modules with Yarn for renderer package
8072
run: |
81-
yarn install --no-progress --no-emoji ${{ matrix.node-version == '22' && '--frozen-lockfile' || '' }}
73+
yarn install --no-progress --no-emoji
8274
sudo yarn global add yalc
8375
- name: Build Renderer package
8476
run: yarn build

0 commit comments

Comments
 (0)