Fix generator validation by using environment variable (#1923)

* Fix generator validation by using environment variable

The ARGV-based check for generator runtime was unreliable because Rails
can modify or clear ARGV during initialization. This caused version
validation to run during generator execution, before the react-on-rails
npm package was installed, resulting in validation errors.

This fix restores the ENV variable approach:
- Generator sets REACT_ON_RAILS_SKIP_VALIDATION=true at start
- Engine checks this ENV var first (before ARGV check)
- Generator clears ENV var in ensure block after completion

The ENV variable persists through Rails initialization, making it more
reliable than ARGV for detecting generator context.

Fixes failing CI tests in examples (3.2, minimum) and examples (3.4, latest)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add workflow_dispatch trigger to enable manual workflow runs

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: justin808

.github/workflows/examples.yml

@@ -11,6 +11,7 @@ on:
     paths-ignore:
       - '**.md'
       - 'docs/**'
+  workflow_dispatch:
 
 jobs:
   detect-changes:

.github/workflows/package-js-tests.yml

@@ -15,6 +15,7 @@ on:
       - 'docs/**'
       - 'lib/**'
       - 'spec/react_on_rails/**'
+  workflow_dispatch:
 
 jobs:
   detect-changes:

lib/generators/react_on_rails/install_generator.rb

@@ -37,6 +37,10 @@ class InstallGenerator < Rails::Generators::Base
       # Removed: --skip-shakapacker-install (Shakapacker is now a required dependency)
 
       def run_generators
+        # Set environment variable to skip validation during generator run
+        # This is inherited by all invoked generators and persists through Rails initialization
+        ENV["REACT_ON_RAILS_SKIP_VALIDATION"] = "true"
+
         if installation_prerequisites_met? || options.ignore_warnings?
           invoke_generators
           add_bin_scripts
@@ -55,6 +59,7 @@ def run_generators
           GeneratorMessages.add_error(error)
         end
       ensure
+        ENV.delete("REACT_ON_RAILS_SKIP_VALIDATION")
         print_generator_messages
       end
 

lib/react_on_rails/engine.rb

@@ -20,6 +20,12 @@ class Engine < ::Rails::Engine
     # Determine if version validation should be skipped
     # @return [Boolean] true if validation should be skipped
     def self.skip_version_validation?
+      # Skip if explicitly disabled via environment variable (set by generators)
+      if ENV["REACT_ON_RAILS_SKIP_VALIDATION"] == "true"
+        Rails.logger.debug "[React on Rails] Skipping validation - disabled via environment variable"
+        return true
+      end
+
       # Check package.json first as it's cheaper and handles more cases
       if package_json_missing?
         Rails.logger.debug "[React on Rails] Skipping validation - package.json not found"

spec/react_on_rails/engine_spec.rb

@@ -13,6 +13,26 @@ module ReactOnRails
         allow(Rails.logger).to receive(:debug)
       end
 
+      context "when REACT_ON_RAILS_SKIP_VALIDATION is set" do
+        before do
+          ENV["REACT_ON_RAILS_SKIP_VALIDATION"] = "true"
+        end
+
+        after do
+          ENV.delete("REACT_ON_RAILS_SKIP_VALIDATION")
+        end
+
+        it "returns true" do
+          expect(described_class.skip_version_validation?).to be true
+        end
+
+        it "logs debug message about environment variable" do
+          described_class.skip_version_validation?
+          expect(Rails.logger).to have_received(:debug)
+            .with("[React on Rails] Skipping validation - disabled via environment variable")
+        end
+      end
+
       context "when package.json doesn't exist" do
         before do
           allow(File).to receive(:exist?).with(package_json_path).and_return(false)