-
Notifications
You must be signed in to change notification settings - Fork 384
Fix ci rspec upgrade to rails 8.0 #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ihab4real
wants to merge
6
commits into
shakacode:master
from
ihab4real:fix-ci-rspec-upgrade-to-rails-8.0
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
31270c4
upgrade rails from 7.1 to 7.2
ihab4real 1d5db17
upgrade to rails 8.0
ihab4real 3f648e0
update db/schema.rb for rails 8.0
ihab4real 0d7e42c
upgrade to redis 5
ihab4real bb2b6cc
upgrade to rubocop 1.69
ihab4real 1ff6d67
fix: new comments not appearing after stimulus submission until manua…
ihab4real File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,2 @@ | ||
| #!/usr/bin/env ruby | ||
| # frozen_string_literal: true | ||
|
|
||
| def installed?(process) | ||
| IO.popen "#{process} -v" | ||
| rescue Errno::ENOENT | ||
| false | ||
| end | ||
|
|
||
| def run(process) | ||
| system "#{process} start -f Procfile.dev" | ||
| rescue Errno::ENOENT | ||
| warn <<~MSG | ||
| ERROR: | ||
| Please ensure `Procfile.dev` exists in your project! | ||
| MSG | ||
| exit! | ||
| end | ||
|
|
||
| if installed? "overmind" | ||
| run "overmind" | ||
| elsif installed? "foreman" | ||
| run "foreman" | ||
| else | ||
| warn <<~MSG | ||
| NOTICE: | ||
| For this script to run, you need either 'overmind' or 'foreman' installed on your machine. Please try this script after installing one of them. | ||
| MSG | ||
| exit! | ||
| end | ||
| exec "./bin/rails", "server", *ARGV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| #!/usr/bin/env ruby | ||
| APP_PATH = File.expand_path('../config/application', __dir__) | ||
| APP_PATH = File.expand_path("../config/application", __dir__) | ||
| require_relative "../config/boot" | ||
| require "rails/commands" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #!/usr/bin/env ruby | ||
| require "rubygems" | ||
| require "bundler/setup" | ||
|
|
||
| # explicit rubocop config increases performance slightly while avoiding config confusion. | ||
| ARGV.unshift("--config", File.expand_path("../.rubocop.yml", __dir__)) | ||
|
|
||
| load Gem.bin_path("rubocop", "rubocop") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update
.rubocop.ymlto setTargetRubyVersion: 3.3The current configuration in
.rubocop.ymlsetsTargetRubyVersion: 2.7, which is outdated compared to the project's Ruby version (3.3.3). This mismatch may prevent RuboCop from utilizing newer Ruby syntax features and could lead to inconsistent code style enforcement..rubocop.yml: UpdateTargetRubyVersionfrom2.7to3.3🔗 Analysis chain
Update RuboCop target Ruby version
With the upgrade to RuboCop 1.69, ensure the target Ruby version in
.rubocop.ymlmatches the project's Ruby version (3.3.3).🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 124