Separate tests workflows (#530) #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit create a separate workflow for each test: * rspec tests * lint * js_tests
ahangarha
suggested changes
Jul 31, 2023
lib/tasks/ci.rake
Outdated
Comment on lines
16
to
39
| desc "Run CI rspec tests" | ||
| task ci_rspec_tests: %i[environment rspec_tests] do | ||
| puts "CI rspec tests" | ||
| puts Rainbow("PASSED").green | ||
| puts "" | ||
| rescue StandardError => e | ||
| puts e.to_s | ||
| puts Rainbow("FAILED").red | ||
| puts "" | ||
| raise(e) | ||
| end | ||
|
|
||
| desc "Run CI js_tests" | ||
| task ci_js_tests: %i[environment js_tests] do | ||
| puts "CI js_tests" | ||
| puts Rainbow("PASSED").green | ||
| puts "" | ||
| rescue StandardError => e | ||
| puts e.to_s | ||
| puts Rainbow("FAILED").red | ||
| puts "" | ||
| raise(e) | ||
| end | ||
|
|
There was a problem hiding this comment.
I think these tasks could go under ci namespace so that we get these tasks:
ci: runsci:allci:allruns all other ci tasksci:jsrunsjs_testsci:rspecruns rspec
ahangarha
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
To me, this PR is good.
There are issues with our tests and our CI workflows. I think we should address them in a separate PR.
The objective of this PR was to get the result faster by running parallel workflows and being able to rerun a single failure without needing to run all. This objective is met.
@Judahmeek what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit create a separate workflow for each test:
* rspec tests
* lint
* js_tests
Closes #530
This change is