Controlplane setup #507
Merged
Controlplane setup #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzirtusss
force-pushed
the
sergey/controlplane-setup
branch
from
94b3977 to
0a3a1e0
Compare
dzirtusss
force-pushed
the
sergey/controlplane-setup
branch
from
1fcc7b3 to
6320e54
Compare
justin808
reviewed
Nov 15, 2022
| - rails | ||
| additional_workloads: | ||
| - redis | ||
| - postgres |
There was a problem hiding this comment.
@dzirtusss why do we nee to list these?
There was a problem hiding this comment.
those are used in ps command atm - ps, ps:start, ps:stop, ps:restart. however, there is no clear plan about their future need atm
dzirtusss
force-pushed
the
sergey/controlplane-setup
branch
from
3b293bd to
2b595ad
Compare
justin808
reviewed
Nov 28, 2022
| RUN yarn install | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN rake react_on_rails:locale && RAILS_ENV=production rake assets:precompile | ||
| RUN rails react_on_rails:locale && RAILS_ENV=production rails assets:precompile |
There was a problem hiding this comment.
Nice to set NODE_ENV=production as well.
justin808
reviewed
Nov 28, 2022
| RUN yarn install | ||
|
|
||
| COPY . . | ||
|
|
||
| RUN rake react_on_rails:locale && RAILS_ENV=production rake assets:precompile | ||
| RUN rails react_on_rails:locale && RAILS_ENV=production rails assets:precompile | ||
|
|
||
| ENV RAILS_ENV=production | ||
| ENV NODE_ENV=production |
There was a problem hiding this comment.
Move these lines above the precompile.
dzirtusss
force-pushed
the
sergey/controlplane-setup
branch
from
4134386 to
41a1e7b
Compare
dzirtusss
force-pushed
the
sergey/controlplane-setup
branch
from
41a1e7b to
4b04f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is